Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] python-xlib: new package
Date: Sat, 6 Jan 2018 15:13:08 +0100	[thread overview]
Message-ID: <20180106151308.7b5765f7@windsurf> (raw)
In-Reply-To: <20180105211307.25071-1-joseph.kogut@gmail.com>

Hello,

On Fri,  5 Jan 2018 13:13:07 -0800, Joseph Kogut wrote:
> Thanks for the review, Yegor!
> 
> Changes since v1:
> - added runtime tag to python-six Config dependency
> - remove unneeded command and newline from python-xlib.hash
> - added host-python-setuptools-scm to build dependencies
> - removed setup.py patch

This personal message and changelog should have gone...

> 
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---

... here, so that Git doesn't include it as part of the commit log.
Indeed, we don't need to keep such details in the Git history (but they
are very useful to have during the patch review process).

> +PYTHON_XLIB_VERSION = 0.21
> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
> +PYTHON_XLIB_SETUP_TYPE = setuptools
> +PYTHON_XLIB_LICENSE = LGPL-2.0+

The license is in fact LGPL-2.1+, so I've fixed that and applied your
patch to the master branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2018-01-06 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05  0:04 [Buildroot] [PATCH 1/1] python-xlib: new package Joseph Kogut
2018-01-05  7:55 ` Yegor Yefremov
2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
2018-01-06 14:13   ` Thomas Petazzoni [this message]
2018-01-07  0:14     ` Matthew Weber
2018-01-07  2:48     ` Joseph Kogut
2018-01-07 10:06       ` Yegor Yefremov
2018-01-14 20:28         ` Joseph Kogut
2018-01-14 20:34           ` Yegor Yefremov
2018-01-13 22:10   ` Yann E. MORIN
2018-01-14 21:16     ` [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning Joseph Kogut
2018-01-14 22:05       ` Yann E. MORIN
2018-01-15 15:38       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180106151308.7b5765f7@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox