From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] nilfs-utils: need NPTL threads
Date: Sat, 6 Jan 2018 15:35:18 +0100 [thread overview]
Message-ID: <20180106153518.2fa78e98@windsurf> (raw)
In-Reply-To: <1515060652-22472-1-git-send-email-dev.kurt@vandijck-laurijssen.be>
Hello,
On Thu, 4 Jan 2018 11:10:51 +0100, Kurt Van Dijck wrote:
> nilfs-utils use clock_nanosleep(), which comes with NPTL threads
>
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> ---
> package/nilfs-utils/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
> index 0c6b7a0..9dda27c 100644
> --- a/package/nilfs-utils/Config.in
> +++ b/package/nilfs-utils/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_NILFS_UTILS
> bool "nilfs-utils"
> depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
> depends on BR2_USE_MMU # util-linux libmount, libblkid
> select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
You forgot to update the Config.in comment accordingly. Also, I've
updated the commit log to summarize why we keep both the threads *and*
NPTL dependencies, even though it might look redundant.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-06 14:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 10:10 [Buildroot] [PATCH 1/2] nilfs-utils: need NPTL threads Kurt Van Dijck
2018-01-04 10:10 ` [Buildroot] [PATCH 2/2] nilfs-utils: fix build with static toolchains Kurt Van Dijck
2018-01-06 14:47 ` Thomas Petazzoni
2018-01-06 20:30 ` Kurt Van Dijck
2018-01-04 10:19 ` [Buildroot] [PATCH 1/2] nilfs-utils: need NPTL threads Baruch Siach
2018-01-04 10:33 ` Thomas Petazzoni
2018-01-04 10:51 ` Baruch Siach
2018-01-04 11:28 ` Kurt Van Dijck
2018-01-04 15:52 ` Yann E. MORIN
2018-01-04 17:23 ` Baruch Siach
[not found] ` <20180104201958.GB5130@waldemar-brodkorb.de>
2018-01-05 5:23 ` Baruch Siach
2018-01-05 10:17 ` Kurt Van Dijck
2018-01-05 10:31 ` Thomas Petazzoni
2018-01-05 11:24 ` Baruch Siach
2018-01-05 13:20 ` Kurt Van Dijck
2018-01-05 14:03 ` Baruch Siach
2018-01-07 20:08 ` Waldemar Brodkorb
2018-01-05 19:56 ` Kurt Van Dijck
2018-01-06 14:35 ` Thomas Petazzoni [this message]
2018-01-06 20:32 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106153518.2fa78e98@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox