* [Buildroot] [PATCH 1/1] package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing
@ 2018-01-07 17:07 Bernd Kuhls
2018-01-07 20:35 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2018-01-07 17:07 UTC (permalink / raw)
To: buildroot
According to https://autotools.io/pkgconfig/pkg_check_modules.html
"In contrast with almost all of the original macros, though, the default
action-if-not-found will end the execution with an error for not having
found the dependency."
Fixes
http://autobuild.buildroot.net/results/cea/cea777dc997f86c1122c8b818d264215a0e77e5a/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
.../0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch b/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
index 20bb0a36d3..0fbe77ef7c 100644
--- a/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
+++ b/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
@@ -23,6 +23,8 @@ and we don't link against it.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+[Bernd: PKG_CHECK_MODULES should not fail when libatomic_ops is missing]
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
amdgpu/Makefile.am | 2 +-
configure.ac | 2 +-
@@ -57,7 +59,7 @@ index 35378b33..501d0871 100644
if test "x$drm_cv_atomic_primitives" = "xnone"; then
- AC_CHECK_HEADER([atomic_ops.h], drm_cv_atomic_primitives="libatomic-ops")
-+ PKG_CHECK_MODULES(ATOMIC_OPS, [atomic_ops], drm_cv_atomic_primitives="libatomic-ops")
++ PKG_CHECK_MODULES(ATOMIC_OPS, [atomic_ops], drm_cv_atomic_primitives="libatomic-ops", true)
fi
# atomic functions defined in <atomic.h> & libc on Solaris
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing
2018-01-07 17:07 [Buildroot] [PATCH 1/1] package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing Bernd Kuhls
@ 2018-01-07 20:35 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-01-07 20:35 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 7 Jan 2018 18:07:38 +0100, Bernd Kuhls wrote:
> According to https://autotools.io/pkgconfig/pkg_check_modules.html
> "In contrast with almost all of the original macros, though, the default
> action-if-not-found will end the execution with an error for not having
> found the dependency."
>
> Fixes
> http://autobuild.buildroot.net/results/cea/cea777dc997f86c1122c8b818d264215a0e77e5a/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
This commit log was a bit light in explanation, so improved it and
applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-07 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-07 17:07 [Buildroot] [PATCH 1/1] package/libdrm: PKG_CHECK_MODULES should not fail when libatomic_ops is missing Bernd Kuhls
2018-01-07 20:35 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox