* [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package
@ 2018-01-04 12:28 Jan Heylen
2018-01-04 12:28 ` [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk Jan Heylen
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Jan Heylen @ 2018-01-04 12:28 UTC (permalink / raw)
To: buildroot
From: Jan Heylen <jan.heylen@nokia.com>
Hi,
V6 of "this adds opentracing-cpp package as a logging library package."
added a patch for m68k cf toolchains suffering from BR2_TOOLCHAIN_HAS_GCC_BUG_64735
br,
Jan
Jan Heylen (4):
rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk
pkg-cmake: add note on BUILD_STATIC_LIBS
m68k_cf5208: suffers from gcc 64735
opentracing-cpp: new package
DEVELOPERS | 3 +
package/Config.in | 1 +
...shared-static-target-a-configurable-optio.patch | 74 ++++++++++++++++++++++
package/opentracing-cpp/Config.in | 15 +++++
package/opentracing-cpp/opentracing-cpp.hash | 3 +
package/opentracing-cpp/opentracing-cpp.mk | 25 ++++++++
package/pkg-cmake.mk | 9 +++
package/rabbitmq-c/rabbitmq-c.mk | 7 +-
toolchain/toolchain-common.in | 1 +
9 files changed, 135 insertions(+), 3 deletions(-)
create mode 100644 package/opentracing-cpp/0001-CMake-make-shared-static-target-a-configurable-optio.patch
create mode 100644 package/opentracing-cpp/Config.in
create mode 100644 package/opentracing-cpp/opentracing-cpp.hash
create mode 100644 package/opentracing-cpp/opentracing-cpp.mk
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk 2018-01-04 12:28 [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package Jan Heylen @ 2018-01-04 12:28 ` Jan Heylen 2018-01-07 22:44 ` Thomas Petazzoni 2018-01-04 12:28 ` [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS Jan Heylen ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Jan Heylen @ 2018-01-04 12:28 UTC (permalink / raw) To: buildroot From: Jan Heylen <jan.heylen@nokia.com> Signed-off-by: Jan Heylen <jan.heylen@nokia.com> --- package/rabbitmq-c/rabbitmq-c.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/rabbitmq-c/rabbitmq-c.mk b/package/rabbitmq-c/rabbitmq-c.mk index eef09ec..d496a4c 100644 --- a/package/rabbitmq-c/rabbitmq-c.mk +++ b/package/rabbitmq-c/rabbitmq-c.mk @@ -13,12 +13,13 @@ RABBITMQ_C_CONF_OPTS = \ -DBUILD_API_DOCS=OFF \ -DBUILD_TOOLS_DOCS=OFF +# BUILD_SHARED_LIBS is handled in pkg-cmake.mk as it is a generic cmake variable ifeq ($(BR2_STATIC_LIBS),y) -RABBITMQ_C_CONF_OPTS += -DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON +RABBITMQ_C_CONF_OPTS += -DBUILD_STATIC_LIBS=ON else ifeq ($(BR2_SHARED_STATIC_LIBS),y) -RABBITMQ_C_CONF_OPTS += -DBUILD_SHARED_LIBS=ON -DBUILD_STATIC_LIBS=ON +RABBITMQ_C_CONF_OPTS += -DBUILD_STATIC_LIBS=ON else ifeq ($(BR2_SHARED_LIBS),y) -RABBITMQ_C_CONF_OPTS += -DBUILD_SHARED_LIBS=ON -DBUILD_STATIC_LIBS=OFF +RABBITMQ_C_CONF_OPTS += -DBUILD_STATIC_LIBS=OFF endif # CMake OpenSSL detection is buggy, and doesn't properly use -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk 2018-01-04 12:28 ` [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk Jan Heylen @ 2018-01-07 22:44 ` Thomas Petazzoni 0 siblings, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2018-01-07 22:44 UTC (permalink / raw) To: buildroot Hello, On Thu, 4 Jan 2018 13:28:28 +0100, Jan Heylen wrote: > From: Jan Heylen <jan.heylen@nokia.com> > > Signed-off-by: Jan Heylen <jan.heylen@nokia.com> I've applied, after tweaking a bit the commit title and commit log: rabbitmq-c: don't pass BUILD_SHARED_LIBS The BUILD_SHARED_LIBS option is already handled by the cmake-package infrastructure, so there is no need to pass it at the package level. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS 2018-01-04 12:28 [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package Jan Heylen 2018-01-04 12:28 ` [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk Jan Heylen @ 2018-01-04 12:28 ` Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni 2018-01-04 12:28 ` [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 Jan Heylen 2018-01-04 12:28 ` [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package Jan Heylen 3 siblings, 1 reply; 10+ messages in thread From: Jan Heylen @ 2018-01-04 12:28 UTC (permalink / raw) To: buildroot From: Jan Heylen <jan.heylen@nokia.com> as BUILD_STATIC_LIBS is not a standard cmake variable (while BUILD_SHARED_LIBS is) we shouldn't add it in pkg-cmake.mk, although for some packages that would make sense. Therefore, add a note so we don't forget about this abnormality. see: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior Signed-off-by: Jan Heylen <jan.heylen@nokia.com> --- package/pkg-cmake.mk | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 6739704..b75cb98 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -80,6 +80,15 @@ ifndef $(2)_CONFIGURE_CMDS ifeq ($(4),target) # Configure package for target +# +# Note: +# BUILD_SHARED_LIBS is a cmake internal variable, +# BUILD_STATIC_LIBS is not standard in any way, which means some +# projects may choose another name for a similar option and there is not +# much we can do about this. +# see: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior +# +# So: we handle BUILD_SHARED_LIBS here, but BUILD_STATIC_LIBS must be handled per package define $(2)_CONFIGURE_CMDS (mkdir -p $$($$(PKG)_BUILDDIR) && \ cd $$($$(PKG)_BUILDDIR) && \ -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS 2018-01-04 12:28 ` [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS Jan Heylen @ 2018-01-07 22:45 ` Thomas Petazzoni 0 siblings, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2018-01-07 22:45 UTC (permalink / raw) To: buildroot Hello, On Thu, 4 Jan 2018 13:28:29 +0100, Jan Heylen wrote: > +# > +# Note: > +# BUILD_SHARED_LIBS is a cmake internal variable, > +# BUILD_STATIC_LIBS is not standard in any way, which means some > +# projects may choose another name for a similar option and there is not > +# much we can do about this. > +# see: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior > +# I've applied, after rewording this a bit differently: +# +# - We are passing BUILD_SHARED_LIBS because it is documented as a +# standard CMake variable to control the build of shared libraries +# (see https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior) +# - We are not passing BUILD_STATIC_LIBS because it is *not* +# documented as a standard CMake variable. If a package supports it, +# it must handle it explicitly. +# Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 2018-01-04 12:28 [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package Jan Heylen 2018-01-04 12:28 ` [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk Jan Heylen 2018-01-04 12:28 ` [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS Jan Heylen @ 2018-01-04 12:28 ` Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni 2018-01-08 21:53 ` Peter Korsgaard 2018-01-04 12:28 ` [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package Jan Heylen 3 siblings, 2 replies; 10+ messages in thread From: Jan Heylen @ 2018-01-04 12:28 UTC (permalink / raw) To: buildroot From: Jan Heylen <jan.heylen@nokia.com> so add it to the list of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 Identified experimentally by using exception_ptr with m68k_cf5208 and looking at the value of ATOMIC_INT_LOCK_FREE. ATOMIC_INT_LOCK_FREE = 1, so the issue is present. Also verified that gcc 7.x fixed it also for cf5208. Signed-off-by: Jan Heylen <jan.heylen@nokia.com> --- toolchain/toolchain-common.in | 1 + 1 file changed, 1 insertion(+) diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in index d743c63..0000713 100644 --- a/toolchain/toolchain-common.in +++ b/toolchain/toolchain-common.in @@ -22,6 +22,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 default y if BR2_ARM_CPU_ARMV4 default y if BR2_ARM_CPU_ARMV5 default y if BR2_sparc_v8 + default y if BR2_m68k_cf5208 depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 config BR2_TOOLCHAIN_HAS_NATIVE_RPC -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 2018-01-04 12:28 ` [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 Jan Heylen @ 2018-01-07 22:45 ` Thomas Petazzoni 2018-01-08 21:53 ` Peter Korsgaard 1 sibling, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2018-01-07 22:45 UTC (permalink / raw) To: buildroot Hello, On Thu, 4 Jan 2018 13:28:30 +0100, Jan Heylen wrote: > From: Jan Heylen <jan.heylen@nokia.com> > > so add it to the list of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > > Identified experimentally by using exception_ptr with m68k_cf5208 and > looking at the value of ATOMIC_INT_LOCK_FREE. ATOMIC_INT_LOCK_FREE = 1, > so the issue is present. Also verified that gcc 7.x fixed it also for cf5208. > > Signed-off-by: Jan Heylen <jan.heylen@nokia.com> I've applied, after slightly tweaking the commit log: toolchain: m68k coldfire is also affected by gcc bug 64735 Verified experimentally by using exception_ptr with m68k_cf5208 and looking at the value of ATOMIC_INT_LOCK_FREE. ATOMIC_INT_LOCK_FREE=1, so the issue is present. Also verified that gcc 7.x fixed it also for cf5208. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 2018-01-04 12:28 ` [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni @ 2018-01-08 21:53 ` Peter Korsgaard 1 sibling, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2018-01-08 21:53 UTC (permalink / raw) To: buildroot >>>>> "Jan" == Jan Heylen <heyleke@gmail.com> writes: > From: Jan Heylen <jan.heylen@nokia.com> > so add it to the list of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > Identified experimentally by using exception_ptr with m68k_cf5208 and > looking at the value of ATOMIC_INT_LOCK_FREE. ATOMIC_INT_LOCK_FREE = 1, > so the issue is present. Also verified that gcc 7.x fixed it also for cf5208. > Signed-off-by: Jan Heylen <jan.heylen@nokia.com> Committed to 2017.11.x, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package 2018-01-04 12:28 [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package Jan Heylen ` (2 preceding siblings ...) 2018-01-04 12:28 ` [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 Jan Heylen @ 2018-01-04 12:28 ` Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni 3 siblings, 1 reply; 10+ messages in thread From: Jan Heylen @ 2018-01-04 12:28 UTC (permalink / raw) To: buildroot From: Jan Heylen <jan.heylen@nokia.com> Signed-off-by: Jan Heylen <jan.heylen@nokia.com> --- test-pkg passes Changes v5 -> v6: - removed BR2_m68k_cf dependency, moved it to separate and generic BR2_TOOLCHAIN_HAS_GCC_BUG_64735 patch - fixed comment on toolchain requirement Changes v4 -> v5: - added static switch again, as pck-cmake can only handle shared libs variable part Changes v3 -> v4: - remove shared/static switch in mk file as that is handled in pkg-cmake.mk now Changes v2 -> v3: - Fix another indendation typo - Add DEVELOPERS file change - Signoff opetracing-cpp patch - run test-pkg and include various dependencies (toolchain bug & m68k cf) - add comments in Config.in on the dependencies Changes v1 -> v2: - Fix indendation typo - Add licence hash - remove INTALL_TARGET=yes as that is default --- DEVELOPERS | 3 + package/Config.in | 1 + ...shared-static-target-a-configurable-optio.patch | 74 ++++++++++++++++++++++ package/opentracing-cpp/Config.in | 15 +++++ package/opentracing-cpp/opentracing-cpp.hash | 3 + package/opentracing-cpp/opentracing-cpp.mk | 25 ++++++++ 6 files changed, 121 insertions(+) create mode 100644 package/opentracing-cpp/0001-CMake-make-shared-static-target-a-configurable-optio.patch create mode 100644 package/opentracing-cpp/Config.in create mode 100644 package/opentracing-cpp/opentracing-cpp.hash create mode 100644 package/opentracing-cpp/opentracing-cpp.mk diff --git a/DEVELOPERS b/DEVELOPERS index fe989c0..f17fcdd 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -790,6 +790,9 @@ F: package/pangomm/ F: package/rpm/ F: package/yad/ +N: Jan Heylen <jan.heylen@nokia.com> +F: package/opentracing-cpp/ + N: Jan Kraval <jan.kraval@gmail.com> F: board/orangepi/orangepi-lite F: configs/orangepi_lite_defconfig diff --git a/package/Config.in b/package/Config.in index bd39a37..1150a3f 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1288,6 +1288,7 @@ menu "Logging" source "package/log4cplus/Config.in" source "package/log4cpp/Config.in" source "package/log4cxx/Config.in" + source "package/opentracing-cpp/Config.in" source "package/zlog/Config.in" endmenu diff --git a/package/opentracing-cpp/0001-CMake-make-shared-static-target-a-configurable-optio.patch b/package/opentracing-cpp/0001-CMake-make-shared-static-target-a-configurable-optio.patch new file mode 100644 index 0000000..90a945b --- /dev/null +++ b/package/opentracing-cpp/0001-CMake-make-shared-static-target-a-configurable-optio.patch @@ -0,0 +1,74 @@ +From 9462847f23a25524fdc2112cbc8de3f2c02a1669 Mon Sep 17 00:00:00 2001 +From: Jan Heylen <jan.heylen@nokia.com> +Date: Fri, 22 Dec 2017 22:04:29 +0100 +Subject: [PATCH] CMake: make shared/static target a configurable option + +Signed-off-by: Jan Heylen <jan.heylen@nokia.com> +--- + CMakeLists.txt | 40 ++++++++++++++++++++++++++++------------ + 1 file changed, 28 insertions(+), 12 deletions(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index aadf2f9..d03bd00 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -70,18 +70,36 @@ endif() + include_directories(include) + include_directories(SYSTEM 3rd_party/include) + ++option(BUILD_SHARED_LIBS "Build as a shared library" ON) ++option(BUILD_STATIC_LIBS "Build as a static library" ON) ++ ++if (NOT BUILD_SHARED_LIBS AND NOT BUILD_STATIC_LIBS) ++ message(FATAL_ERROR "One or both of BUILD_SHARED_LIBS or BUILD_STATIC_LIBS must be set to ON to build") ++endif() ++ + set(SRCS src/propagation.cpp src/noop.cpp src/tracer.cpp) +-add_library(opentracing SHARED ${SRCS}) +-target_include_directories(opentracing INTERFACE "$<INSTALL_INTERFACE:include/>") +-set_target_properties(opentracing PROPERTIES VERSION ${OPENTRACING_VERSION_STRING} ++ ++if (BUILD_SHARED_LIBS) ++ add_library(opentracing SHARED ${SRCS}) ++ target_include_directories(opentracing INTERFACE "$<INSTALL_INTERFACE:include/>") ++ set_target_properties(opentracing PROPERTIES VERSION ${OPENTRACING_VERSION_STRING} + SOVERSION ${OPENTRACING_VERSION_MAJOR}) +-add_library(opentracing-static STATIC ${SRCS}) +-set_target_properties(opentracing-static PROPERTIES OUTPUT_NAME opentracing) +-target_include_directories(opentracing-static INTERFACE "$<INSTALL_INTERFACE:include/>") +-if (CLANG_TIDY_EXE) +- set_target_properties(opentracing PROPERTIES ++ install(TARGETS opentracing EXPORT OpenTracingTargets ++ LIBRARY DESTINATION lib ++ ARCHIVE DESTINATION lib) ++ if (CLANG_TIDY_EXE) ++ set_target_properties(opentracing PROPERTIES + CXX_CLANG_TIDY "${DO_CLANG_TIDY}") +-endif() ++ endif() ++endif(BUILD_SHARED_LIBS) ++ ++if (BUILD_STATIC_LIBS) ++ add_library(opentracing-static STATIC ${SRCS}) ++ set_target_properties(opentracing-static PROPERTIES OUTPUT_NAME opentracing) ++ target_include_directories(opentracing-static INTERFACE "$<INSTALL_INTERFACE:include/>") ++ install(TARGETS opentracing-static EXPORT OpenTracingTargets ++ ARCHIVE DESTINATION lib) ++endif(BUILD_STATIC_LIBS) + + + install(DIRECTORY 3rd_party/include/opentracing DESTINATION include +@@ -89,9 +107,7 @@ install(DIRECTORY 3rd_party/include/opentracing DESTINATION include + PATTERN "*.h") + install(DIRECTORY include/opentracing DESTINATION include + FILES_MATCHING PATTERN "*.h") +-install(TARGETS opentracing opentracing-static EXPORT OpenTracingTargets +- LIBRARY DESTINATION lib +- ARCHIVE DESTINATION lib) ++ + + # ============================================================================== + # Package configuration setup +-- +2.7.4 + diff --git a/package/opentracing-cpp/Config.in b/package/opentracing-cpp/Config.in new file mode 100644 index 0000000..4ee7b29 --- /dev/null +++ b/package/opentracing-cpp/Config.in @@ -0,0 +1,15 @@ +config BR2_PACKAGE_OPENTRACING_CPP + bool "opentracing-cpp" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 + depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr + help + OpenTracing API for C++ + + http://opentracing.io + +comment "opentracing-cpp needs a toolchain w/ C++, gcc >= 4.8" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + +comment "opentracing-cpp needs exception_ptr" + depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 diff --git a/package/opentracing-cpp/opentracing-cpp.hash b/package/opentracing-cpp/opentracing-cpp.hash new file mode 100644 index 0000000..d25dbaf --- /dev/null +++ b/package/opentracing-cpp/opentracing-cpp.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 c77041cb2f147ac81b2b0702abfced5565a9cebc318d045c060a4c3e074009ee opentracing-cpp-v1.2.0.tar.gz +sha256 b80bffcfee825a69645f7ca97ddba48714031ea5c845198d184714d5490798b6 COPYING diff --git a/package/opentracing-cpp/opentracing-cpp.mk b/package/opentracing-cpp/opentracing-cpp.mk new file mode 100644 index 0000000..4e296fc --- /dev/null +++ b/package/opentracing-cpp/opentracing-cpp.mk @@ -0,0 +1,25 @@ +################################################################################ +# +# opentracing-cpp +# +################################################################################ + +OPENTRACING_CPP_VERSION = v1.2.0 +OPENTRACING_CPP_SITE = $(call github,opentracing,opentracing-cpp,$(OPENTRACING_CPP_VERSION)) +OPENTRACING_CPP_LICENSE = MIT +OPENTRACING_CPP_LICENSE_FILES = COPYING + +OPENTRACING_CPP_INSTALL_STAGING = YES + +# BUILD_SHARED_LIBS is handled in pkg-cmake.mk as it is a generic cmake variable +# although BUILD_STATIC_LIBS=ON is default, make it explicit, +# cmake and static/shared libs is confusing enough already. +ifeq ($(BR2_STATIC_LIBS),y) +OPENTRACING_CPP_CONF_OPTS += -DBUILD_STATIC_LIBS=ON +else ifeq ($(BR2_SHARED_STATIC_LIBS),y) +OPENTRACING_CPP_CONF_OPTS += -DBUILD_STATIC_LIBS=ON +else ifeq ($(BR2_SHARED_LIBS),y) +OPENTRACING_CPP_CONF_OPTS += -DBUILD_STATIC_LIBS=OFF +endif + +$(eval $(cmake-package)) -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package 2018-01-04 12:28 ` [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package Jan Heylen @ 2018-01-07 22:45 ` Thomas Petazzoni 0 siblings, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2018-01-07 22:45 UTC (permalink / raw) To: buildroot Hello, On Thu, 4 Jan 2018 13:28:31 +0100, Jan Heylen wrote: > From: Jan Heylen <jan.heylen@nokia.com> > > Signed-off-by: Jan Heylen <jan.heylen@nokia.com> > --- > test-pkg passes Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-01-08 21:53 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-01-04 12:28 [Buildroot] [PATCH v6 0/4] Opentracing-cpp: new package Jan Heylen 2018-01-04 12:28 ` [Buildroot] [PATCH v6 1/4] rabbitmq-c: BUILD_SHARED_LIBS is handled in pkg-cmake.mk Jan Heylen 2018-01-07 22:44 ` Thomas Petazzoni 2018-01-04 12:28 ` [Buildroot] [PATCH v6 2/4] pkg-cmake: add note on BUILD_STATIC_LIBS Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni 2018-01-04 12:28 ` [Buildroot] [PATCH v6 3/4] m68k_cf5208: suffers from gcc 64735 Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni 2018-01-08 21:53 ` Peter Korsgaard 2018-01-04 12:28 ` [Buildroot] [PATCH v6 4/4] opentracing-cpp: new package Jan Heylen 2018-01-07 22:45 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox