[Buildroot] [PATCH] ntp: does not work with libressl

[Buildroot] [PATCH] ntp: does not work with libressl

[Peter Korsgaard]

Fixes #10556

The --with-crypto handling in ntp only works with libopenssl, not with
libressl, where it ends up with compilation issues like:

ntp_control.c:(.text+0x64): undefined reference to `EVP_MD_CTX_new'
ntp_control.c:(.text+0x10c): undefined reference to `EVP_MD_CTX_free'
libntpd.a(ntp_crypto.o): In function `bighash':
ntp_crypto.c:(.text+0x2e8): undefined reference to `EVP_MD_CTX_new'
ntp_crypto.c:(.text+0x328): undefined reference to `EVP_MD_CTX_free'
libntpd.a(ntp_crypto.o): In function `crypto_verify':
ntp_crypto.c:(.text+0x6cc): undefined reference to `EVP_MD_CTX_new'
ntp_crypto.c:(.text+0x710): undefined reference to `EVP_MD_CTX_free'
ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'

So ensure we only pass --with-crypto when libopenssl is used.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/ntp/ntp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ntp/ntp.mk b/package/ntp/ntp.mk
index 05619aef7c..74cf546988 100644
--- a/package/ntp/ntp.mk
+++ b/package/ntp/ntp.mk
@@ -23,7 +23,7 @@ NTP_CONF_OPTS = \
 # 0003-ntpq-fpic.patch
 NTP_AUTORECONF = YES
 
-ifeq ($(BR2_PACKAGE_OPENSSL),y)
+ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
 NTP_CONF_OPTS += --with-crypto
 NTP_DEPENDENCIES += openssl
 else
-- 
2.11.0

[Buildroot] [PATCH] ntp: does not work with libressl

[Thomas Petazzoni]

Hello,

On Sun,  7 Jan 2018 23:59:40 +0100, Peter Korsgaard wrote:
> Fixes #10556
> 
> The --with-crypto handling in ntp only works with libopenssl, not with
> libressl, where it ends up with compilation issues like:
> 
> ntp_control.c:(.text+0x64): undefined reference to `EVP_MD_CTX_new'
> ntp_control.c:(.text+0x10c): undefined reference to `EVP_MD_CTX_free'
> libntpd.a(ntp_crypto.o): In function `bighash':
> ntp_crypto.c:(.text+0x2e8): undefined reference to `EVP_MD_CTX_new'
> ntp_crypto.c:(.text+0x328): undefined reference to `EVP_MD_CTX_free'
> libntpd.a(ntp_crypto.o): In function `crypto_verify':
> ntp_crypto.c:(.text+0x6cc): undefined reference to `EVP_MD_CTX_new'
> ntp_crypto.c:(.text+0x710): undefined reference to `EVP_MD_CTX_free'
> ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'
> 
> So ensure we only pass --with-crypto when libopenssl is used.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/ntp/ntp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] ntp: does not work with libressl

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes #10556
 > The --with-crypto handling in ntp only works with libopenssl, not with
 > libressl, where it ends up with compilation issues like:

 > ntp_control.c:(.text+0x64): undefined reference to `EVP_MD_CTX_new'
 > ntp_control.c:(.text+0x10c): undefined reference to `EVP_MD_CTX_free'
 > libntpd.a(ntp_crypto.o): In function `bighash':
 > ntp_crypto.c:(.text+0x2e8): undefined reference to `EVP_MD_CTX_new'
 > ntp_crypto.c:(.text+0x328): undefined reference to `EVP_MD_CTX_free'
 > libntpd.a(ntp_crypto.o): In function `crypto_verify':
 > ntp_crypto.c:(.text+0x6cc): undefined reference to `EVP_MD_CTX_new'
 > ntp_crypto.c:(.text+0x710): undefined reference to `EVP_MD_CTX_free'
 > ntp_crypto.c:(.text+0x72c): undefined reference to `EVP_MD_CTX_free'

 > So ensure we only pass --with-crypto when libopenssl is used.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2017.11.x, thanks.

-- 
Bye, Peter Korsgaard