From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Date: Thu, 11 Jan 2018 18:31:04 +0100 [thread overview]
Message-ID: <20180111173104.GB3559@scaer> (raw)
In-Reply-To: <20180110221402.19743-1-thomas.petazzoni@free-electrons.com>
On 2018-01-10 23:14 +0100, Thomas Petazzoni spake thusly:
> When systemd is used as the init system, the
> BR2_TARGET_GENERIC_GETTY_TERM and BR2_TARGET_GENERIC_GETTY_OPTIONS are
> completely ignored, which might confuse the user, as reported in bug
>
> For now, let's simply make those options visible only with busybox
> init and sysv init, as suggested by Yann E. Morin in the discussion of
> bug #10301.
>
> Fixes #10301.
>
> Reported-by: Michael Heinemann <posted@heine.so>
> Suggested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> system/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/system/Config.in b/system/Config.in
> index b9714923c4..0fe0fb60b4 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -355,12 +355,16 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE
> config BR2_TARGET_GENERIC_GETTY_TERM
> string "TERM environment variable"
> default "vt100"
> + # currently not observed by systemd
> + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Why not:
depends on !BR2_INIT_SYSTEMD
because this is really want we want to express: this is not compatible
with systemd...
> help
> Specify a TERM type.
>
> config BR2_TARGET_GENERIC_GETTY_OPTIONS
> string "other options to pass to getty"
> default ""
> + # currently not observed by systemd
> + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Ditto...
Regards,
Yann E. MORIN.
> help
> Any other flags you want to pass to getty,
> Refer to getty --help for details.
> --
> 2.14.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-01-11 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:14 [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd Thomas Petazzoni
2018-01-11 17:31 ` Yann E. MORIN [this message]
2018-01-12 9:02 ` Thomas Petazzoni
2018-01-12 17:39 ` Yann E. MORIN
2018-01-12 21:09 ` Thomas Petazzoni
2018-01-12 21:10 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111173104.GB3559@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox