From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Date: Fri, 12 Jan 2018 18:39:53 +0100 [thread overview]
Message-ID: <20180112173953.GC3226@scaer> (raw)
In-Reply-To: <20180112100216.36d494c1@windsurf.lan>
Thomas, All,
On 2018-01-12 10:02 +0100, Thomas Petazzoni spake thusly:
> On Thu, 11 Jan 2018 18:31:04 +0100, Yann E. MORIN wrote:
> > > + # currently not observed by systemd
> > > + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
> >
> > Why not:
> > depends on !BR2_INIT_SYSTEMD
> >
> > because this is really want we want to express: this is not compatible
> > with systemd...
>
> No, what we really want to express is that
> BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox
> code and sysvinit code. It's not so much that they are not compatible
> with systemd, it is that only busybox and sysvinit observe those
> options.
Then change the title and commit to something like:
system: only expose getty option for busybox and sysvinit
Only busybox and sysvinit handle those options; the other init
systems do not.
So, protect those options behind appropriate dependencies on
busybox or sysvinit.
Fixes #10301.
And then you can add my:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-01-12 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:14 [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd Thomas Petazzoni
2018-01-11 17:31 ` Yann E. MORIN
2018-01-12 9:02 ` Thomas Petazzoni
2018-01-12 17:39 ` Yann E. MORIN [this message]
2018-01-12 21:09 ` Thomas Petazzoni
2018-01-12 21:10 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112173953.GC3226@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox