* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
@ 2018-01-10 22:14 Thomas Petazzoni
2018-01-11 17:31 ` Yann E. MORIN
2018-01-12 21:10 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-01-10 22:14 UTC (permalink / raw)
To: buildroot
When systemd is used as the init system, the
BR2_TARGET_GENERIC_GETTY_TERM and BR2_TARGET_GENERIC_GETTY_OPTIONS are
completely ignored, which might confuse the user, as reported in bug
For now, let's simply make those options visible only with busybox
init and sysv init, as suggested by Yann E. Morin in the discussion of
bug #10301.
Fixes #10301.
Reported-by: Michael Heinemann <posted@heine.so>
Suggested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
system/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/system/Config.in b/system/Config.in
index b9714923c4..0fe0fb60b4 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -355,12 +355,16 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE
config BR2_TARGET_GENERIC_GETTY_TERM
string "TERM environment variable"
default "vt100"
+ # currently not observed by systemd
+ depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
help
Specify a TERM type.
config BR2_TARGET_GENERIC_GETTY_OPTIONS
string "other options to pass to getty"
default ""
+ # currently not observed by systemd
+ depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
help
Any other flags you want to pass to getty,
Refer to getty --help for details.
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
2018-01-10 22:14 [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd Thomas Petazzoni
@ 2018-01-11 17:31 ` Yann E. MORIN
2018-01-12 9:02 ` Thomas Petazzoni
2018-01-12 21:10 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2018-01-11 17:31 UTC (permalink / raw)
To: buildroot
On 2018-01-10 23:14 +0100, Thomas Petazzoni spake thusly:
> When systemd is used as the init system, the
> BR2_TARGET_GENERIC_GETTY_TERM and BR2_TARGET_GENERIC_GETTY_OPTIONS are
> completely ignored, which might confuse the user, as reported in bug
>
> For now, let's simply make those options visible only with busybox
> init and sysv init, as suggested by Yann E. Morin in the discussion of
> bug #10301.
>
> Fixes #10301.
>
> Reported-by: Michael Heinemann <posted@heine.so>
> Suggested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> system/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/system/Config.in b/system/Config.in
> index b9714923c4..0fe0fb60b4 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -355,12 +355,16 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE
> config BR2_TARGET_GENERIC_GETTY_TERM
> string "TERM environment variable"
> default "vt100"
> + # currently not observed by systemd
> + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Why not:
depends on !BR2_INIT_SYSTEMD
because this is really want we want to express: this is not compatible
with systemd...
> help
> Specify a TERM type.
>
> config BR2_TARGET_GENERIC_GETTY_OPTIONS
> string "other options to pass to getty"
> default ""
> + # currently not observed by systemd
> + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Ditto...
Regards,
Yann E. MORIN.
> help
> Any other flags you want to pass to getty,
> Refer to getty --help for details.
> --
> 2.14.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
2018-01-11 17:31 ` Yann E. MORIN
@ 2018-01-12 9:02 ` Thomas Petazzoni
2018-01-12 17:39 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 9:02 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 11 Jan 2018 18:31:04 +0100, Yann E. MORIN wrote:
> > + # currently not observed by systemd
> > + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
>
> Why not:
> depends on !BR2_INIT_SYSTEMD
>
> because this is really want we want to express: this is not compatible
> with systemd...
No, what we really want to express is that
BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox
code and sysvinit code. It's not so much that they are not compatible
with systemd, it is that only busybox and sysvinit observe those
options.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
2018-01-12 9:02 ` Thomas Petazzoni
@ 2018-01-12 17:39 ` Yann E. MORIN
2018-01-12 21:09 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2018-01-12 17:39 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2018-01-12 10:02 +0100, Thomas Petazzoni spake thusly:
> On Thu, 11 Jan 2018 18:31:04 +0100, Yann E. MORIN wrote:
> > > + # currently not observed by systemd
> > > + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
> >
> > Why not:
> > depends on !BR2_INIT_SYSTEMD
> >
> > because this is really want we want to express: this is not compatible
> > with systemd...
>
> No, what we really want to express is that
> BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox
> code and sysvinit code. It's not so much that they are not compatible
> with systemd, it is that only busybox and sysvinit observe those
> options.
Then change the title and commit to something like:
system: only expose getty option for busybox and sysvinit
Only busybox and sysvinit handle those options; the other init
systems do not.
So, protect those options behind appropriate dependencies on
busybox or sysvinit.
Fixes #10301.
And then you can add my:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
2018-01-12 17:39 ` Yann E. MORIN
@ 2018-01-12 21:09 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 21:09 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Jan 2018 18:39:53 +0100, Yann E. MORIN wrote:
> Then change the title and commit to something like:
>
> system: only expose getty option for busybox and sysvinit
>
> Only busybox and sysvinit handle those options; the other init
> systems do not.
>
> So, protect those options behind appropriate dependencies on
> busybox or sysvinit.
>
> Fixes #10301.
>
> And then you can add my:
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
ACK, thanks for the feedback!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
2018-01-10 22:14 [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd Thomas Petazzoni
2018-01-11 17:31 ` Yann E. MORIN
@ 2018-01-12 21:10 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 21:10 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 10 Jan 2018 23:14:02 +0100, Thomas Petazzoni wrote:
> When systemd is used as the init system, the
> BR2_TARGET_GENERIC_GETTY_TERM and BR2_TARGET_GENERIC_GETTY_OPTIONS are
> completely ignored, which might confuse the user, as reported in bug
>
> For now, let's simply make those options visible only with busybox
> init and sysv init, as suggested by Yann E. Morin in the discussion of
> bug #10301.
>
> Fixes #10301.
>
> Reported-by: Michael Heinemann <posted@heine.so>
> Suggested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> system/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
I've applied, after taking into account the feedback from Yann about
the wording of the commit title and commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-12 21:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-10 22:14 [Buildroot] [PATCH] system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd Thomas Petazzoni
2018-01-11 17:31 ` Yann E. MORIN
2018-01-12 9:02 ` Thomas Petazzoni
2018-01-12 17:39 ` Yann E. MORIN
2018-01-12 21:09 ` Thomas Petazzoni
2018-01-12 21:10 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox