From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libpqxx: apply upstream compilation fix
Date: Mon, 15 Jan 2018 21:20:25 +0100 [thread overview]
Message-ID: <20180115212025.482dad6f@windsurf> (raw)
In-Reply-To: <20180115200055.6404-1-james.knight@rockwellcollins.com>
Hello,
On Mon, 15 Jan 2018 15:00:55 -0500, James Knight wrote:
> Apply an upstream patch which addresses a compilation issue with respect
> to an undefined 'timeval' structure. This issue exists in at least v6.0.
> It is expected that this patch can be removed when libpqxx provides a
> new releases (either v6.0.1 or v6.1).
>
> Fixes:
> http://autobuild.buildroot.net/results/48b015650ede4e55e199538072c7228cccf64422
>
> Signed-off-by: James Knight <james.knight@rockwellcollins.com>
> ---
> package/libpqxx/libpqxx.hash | 1 +
> package/libpqxx/libpqxx.mk | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/libpqxx/libpqxx.hash b/package/libpqxx/libpqxx.hash
> index 372be603c5..6fc388fc89 100644
> --- a/package/libpqxx/libpqxx.hash
> +++ b/package/libpqxx/libpqxx.hash
> @@ -1,3 +1,4 @@
> # Locally computed:
> sha256 81cac92458efd799fadb0374107464320d93eba71de05aedf21afb9c8dda7c3a libpqxx-6.0.0.tar.gz
> sha256 9e1c78fa302e4e9738bf3315b130429035c03fcb0f046531ccd977cb474f6b31 COPYING
> +sha256 85881a11caab61f0c8d10cfef673e48c86e701f5a9fdd6cb344aa4f4beb1f2bf 44970d7331e4f369e160af0135a2d1fc16f27a21.patch
Thanks, but please add the patch itself in package/libpqxx/. We stopped
fetching patches from github this way, because those patches are not
stable, and therefore their hash might change.
Indeed, the line "index ccafa9ce71..23b0953735 100644" contains
references to Git commits, but those references are partial (i.e not
the full 40 digits SHA1). Due to this, when more commits are made to
the same repos, git may add additional digits in this "index" line to
ensure the commit references and non-ambiguous. Good for Git, but bad
for the patch hash.
Hence, please bring the patch inside package/libpqxx/. Thanks! :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-15 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 20:00 [Buildroot] [PATCH 1/1] libpqxx: apply upstream compilation fix James Knight
2018-01-15 20:20 ` Thomas Petazzoni [this message]
2018-01-15 20:32 ` James Knight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115212025.482dad6f@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox