Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/dockerfile: add directives to run as non-root
Date: Sun, 4 Feb 2018 11:04:44 +0100	[thread overview]
Message-ID: <20180204100444.GB2411@scaer> (raw)
In-Reply-To: <87bmh521a5.fsf@dell.be.48ers.dk>

Peter, All,

On 2018-02-03 22:47 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
[--SNIP--]
>  > diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
>  > index d45b23dc23..ebb471f7e5 100644
>  > --- a/support/docker/Dockerfile
>  > +++ b/support/docker/Dockerfile
>  > @@ -28,3 +28,10 @@ RUN apt-get -q -y clean
>  >  RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen
>  >  RUN /usr/sbin/locale-gen
>  
>  > +RUN useradd -ms /bin/bash br-user
>  > +RUN chown -R br-user:br-user /home/br-user
> 
> I don't know much about Docker, but I was of the understanding that each
> run statement creates a new layer and the number of layers should be
> minimized, which is why you normally see stuff like:
> 
> RUN foo && \
>     bar && \
>     foz && \
>     baz

Well, I am no docker expert either, and I just mimicked whatever the
file already looked like, as you can see for the previous two lines...

> E.G. from the official documentation:
> https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers

It's always time for a docker expert to send a fixup patch, eh! ;-)
Or I can have a look if I again get bored not to be in BRU... ;-]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-02-04 10:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06 15:28 [Buildroot] [PATCH] support/dockerfile: add directives to run as non-root Yann E. MORIN
2018-01-12 21:54 ` Thomas Petazzoni
2018-01-13 11:28   ` Yann E. MORIN
2018-01-14 13:02     ` Thomas Petazzoni
2018-01-14 21:32       ` Arnout Vandecappelle
2018-02-03 21:47 ` Peter Korsgaard
2018-02-04 10:04   ` Yann E. MORIN [this message]
2018-02-04 14:46     ` Yann E. MORIN
2018-02-05  3:52     ` Cam Hutchison
2018-02-05  7:18       ` Yann E. MORIN
2018-02-05  9:51         ` Cam Hutchison
2018-02-05 10:56         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180204100444.GB2411@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox