From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/glibc: remove GLIBC_SRC_SUBDIR
Date: Mon, 5 Feb 2018 22:27:18 +0100 [thread overview]
Message-ID: <20180205212718.GB2806@scaer> (raw)
In-Reply-To: <20180205205716.4279-4-romain.naour@gmail.com>
Romain, All,
On 2018-02-05 21:57 +0100, Romain Naour spake thusly:
> GLIBC_SRC_SUBDIR was needed when Buildroot supported
> eglibc which stored all sources in a sub-directory.
> It was not removed by the commit removing eglibc support [1].
>
> [1] 500de2598a4902a0e9ec53f7b475046ff17c6681
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
This can also be applied to master, probably...
Regards,
Yann E. MORIN.
> ---
> package/glibc/glibc.mk | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index fd79d84f15..cf4bdec065 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -20,10 +20,8 @@ GLIBC_VERSION = glibc-2.26-107-g73a92363619e52c458146e903dfb9b1ba823aa40
> GLIBC_SITE = $(call github,bminor,glibc,$(GLIBC_VERSION))
> endif
>
> -GLIBC_SRC_SUBDIR = .
> -
> GLIBC_LICENSE = GPL-2.0+ (programs), LGPL-2.1+, BSD-3-Clause, MIT (library)
> -GLIBC_LICENSE_FILES = $(addprefix $(GLIBC_SRC_SUBDIR)/,COPYING COPYING.LIB LICENSES)
> +GLIBC_LICENSE_FILES = COPYING COPYING.LIB LICENSES
>
> # glibc is part of the toolchain so disable the toolchain dependency
> GLIBC_ADD_TOOLCHAIN_DEPENDENCY = NO
> @@ -86,7 +84,7 @@ define GLIBC_CONFIGURE_CMDS
> $(TARGET_CONFIGURE_OPTS) \
> CFLAGS="-O2 $(GLIBC_EXTRA_CFLAGS)" CPPFLAGS="" \
> CXXFLAGS="-O2 $(GLIBC_EXTRA_CFLAGS)" \
> - $(SHELL) $(@D)/$(GLIBC_SRC_SUBDIR)/configure \
> + $(SHELL) $(@D)/configure \
> ac_cv_path_BASH_SHELL=/bin/bash \
> libc_cv_forced_unwind=yes \
> libc_cv_ssp=no \
> --
> 2.14.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-02-05 21:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:57 [Buildroot] [PATCH 1/5] package/x11r7/xlib_libxshmfence: fix build with glibc 2.27 Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 2/5] package/pulseaudio: only define memfd_create() if not already defined Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 3/5] package/libraw: rename internal powf64 Romain Naour
2018-02-05 20:57 ` [Buildroot] [PATCH 4/5] package/glibc: remove GLIBC_SRC_SUBDIR Romain Naour
2018-02-05 21:27 ` Yann E. MORIN [this message]
2018-02-05 20:57 ` [Buildroot] [PATCH 5/5] package/glibc: bump to 2.27 Romain Naour
2018-02-05 21:01 ` Baruch Siach
2018-02-05 21:16 ` Romain Naour
2018-02-05 21:41 ` Yann E. MORIN
2018-02-05 23:32 ` Peter Korsgaard
2018-02-06 4:15 ` Baruch Siach
2018-02-06 8:18 ` Arnout Vandecappelle
2018-02-06 10:50 ` Baruch Siach
2018-02-06 12:38 ` Arnout Vandecappelle
2018-02-06 13:44 ` Peter Korsgaard
2018-02-06 13:46 ` Baruch Siach
2018-02-06 14:41 ` Peter Korsgaard
2018-02-06 16:40 ` Baruch Siach
2018-02-05 21:08 ` [Buildroot] [PATCH 1/5] package/x11r7/xlib_libxshmfence: fix build with glibc 2.27 Yann E. MORIN
2018-02-06 12:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205212718.GB2806@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox