* [Buildroot] [PATCH 1/1] udftools: new package
@ 2018-01-22 21:31 Steve Kenton
2018-01-31 14:57 ` Marcus Folkesson
2018-02-06 16:08 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Steve Kenton @ 2018-01-22 21:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Steve Kenton <skenton@ou.edu>
---
Try 2: fix stupid copy paste error in Config.in
Try 3: remove duplicate/misplaced addition to master Config.in
I wish I could see these issues when I first look the patch over - sigh
Try 4: Fixes for feedback from Thomas
I computed the hash below for the license file but I did not see any others under the package directory
so I think I must be misunderstanding where it should go from my reading of the on-line manual
# Locally computed
sha256 dcc100d4161cc0b7177545ab6e47216f84857cda3843847c792a25289852dcaa COPYING
I ran ./utils/check-package package/udftools/* and fixed up all the white space errors
But I'm not sure what to do with ./utils/test-pkg, do I need to build all 47 tools chains?
I tried ./utils/test-pkg -p udftools -c udftools.snippet (contents below) but just got errors
BR2_PACKAGE_UDFTOOLS=y
How do I proceed from there?
DEVELOPERS | 1 +
package/Config.in | 1 +
package/udftools/Config.in | 12 ++++++++++++
package/udftools/udftools.hash | 2 ++
package/udftools/udftools.mk | 12 ++++++++++++
5 files changed, 28 insertions(+)
create mode 100644 package/udftools/Config.in
create mode 100644 package/udftools/udftools.hash
create mode 100644 package/udftools/udftools.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 73c0231..1c5ed16 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1681,6 +1681,7 @@ F: package/dvdrw-tools/
F: package/memtest86/
F: package/mjpegtools/
F: package/tovid/
+F: package/udftools/
F: package/xorriso/
N: Steve Thomas <scjthm@live.com>
diff --git a/package/Config.in b/package/Config.in
index 00451f5..7b3531c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -196,6 +196,7 @@ menu "Filesystem and flash utilities"
source "package/squashfs/Config.in"
source "package/sshfs/Config.in"
source "package/sunxi-tools/Config.in"
+ source "package/udftools/Config.in"
source "package/unionfs/Config.in"
source "package/xfsprogs/Config.in"
endmenu
diff --git a/package/udftools/Config.in b/package/udftools/Config.in
new file mode 100644
index 0000000..bbccd60
--- /dev/null
+++ b/package/udftools/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_UDFTOOLS
+ bool "udftools"
+ depends on BR2_USE_WCHAR
+ select BR2_PACKAGE_READLINE
+ help
+ Tools for creating UDF filesystems
+ Maintained fork of the 2004 Sourcforge package
+
+ https://github.com/pali/udftools
+
+comment "udftools needs a toolchain w/ wchar"
+ depends on !BR2_USE_WCHAR
diff --git a/package/udftools/udftools.hash b/package/udftools/udftools.hash
new file mode 100644
index 0000000..b297edf
--- /dev/null
+++ b/package/udftools/udftools.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 67fe428d452901215cfad8049d250540c97114b1a20dd63277b91c2c4fae8292 udftools-2.0.tar.gz
diff --git a/package/udftools/udftools.mk b/package/udftools/udftools.mk
new file mode 100644
index 0000000..708fef9
--- /dev/null
+++ b/package/udftools/udftools.mk
@@ -0,0 +1,12 @@
+################################################################################
+#
+# udftools
+#
+################################################################################
+
+UDFTOOLS_VERSION = 2.0
+UDFTOOLS_SITE = https://github.com/pali/udftools/releases/download/$(UDFTOOLS_VERSION)
+UDFTOOLS_LICENSE = GPL-2.0+
+UDFTOOLS_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
--
2.9.0.137.gcf4c2cf
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] udftools: new package
2018-01-22 21:31 [Buildroot] [PATCH 1/1] udftools: new package Steve Kenton
@ 2018-01-31 14:57 ` Marcus Folkesson
2018-02-06 16:08 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Marcus Folkesson @ 2018-01-31 14:57 UTC (permalink / raw)
To: buildroot
Hi Steve,
On Mon, Jan 22, 2018 at 03:31:38PM -0600, Steve Kenton wrote:
> Signed-off-by: Steve Kenton <skenton@ou.edu>
> I computed the hash below for the license file but I did not see any others under the package directory
> so I think I must be misunderstanding where it should go from my reading of the on-line manual
?
> # Locally computed
> sha256 dcc100d4161cc0b7177545ab6e47216f84857cda3843847c792a25289852dcaa COPYING
> I ran ./utils/check-package package/udftools/* and fixed up all the white space errors
> But I'm not sure what to do with ./utils/test-pkg, do I need to build all 47 tools chains?
> I tried ./utils/test-pkg -p udftools -c udftools.snippet (contents below) but just got errors
> BR2_PACKAGE_UDFTOOLS=y
> diff --git a/package/udftools/udftools.hash b/package/udftools/udftools.hash
> new file mode 100644
> index 0000000..b297edf
> --- /dev/null
> +++ b/package/udftools/udftools.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
Sorry, I don't understand your comments. The computed hash should go
here
> +sha256 67fe428d452901215cfad8049d250540c97114b1a20dd63277b91c2c4fae8292 udftools-2.0.tar.gz
sha256 dcc100d4161cc0b7177545ab6e47216f84857cda3843847c792a25289852dcaa COPYING
> diff --git a/package/udftools/udftools.mk b/package/udftools/udftools.mk
> new file mode 100644
> index 0000000..708fef9
> --- /dev/null
> +++ b/package/udftools/udftools.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# udftools
> +#
> +################################################################################
> +
> +UDFTOOLS_VERSION = 2.0
> +UDFTOOLS_SITE = https://github.com/pali/udftools/releases/download/$(UDFTOOLS_VERSION)
> +UDFTOOLS_LICENSE = GPL-2.0+
The license is "GPL-2.0".
> +UDFTOOLS_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))
> --
> 2.9.0.137.gcf4c2cf
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180131/2c2695f6/attachment.asc>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] udftools: new package
2018-01-22 21:31 [Buildroot] [PATCH 1/1] udftools: new package Steve Kenton
2018-01-31 14:57 ` Marcus Folkesson
@ 2018-02-06 16:08 ` Thomas Petazzoni
2018-02-08 13:22 ` Marcus Folkesson
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-02-06 16:08 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 22 Jan 2018 15:31:38 -0600, Steve Kenton wrote:
> Signed-off-by: Steve Kenton <skenton@ou.edu>
> ---
> Try 2: fix stupid copy paste error in Config.in
> Try 3: remove duplicate/misplaced addition to master Config.in
> I wish I could see these issues when I first look the patch over - sigh
> Try 4: Fixes for feedback from Thomas
> I computed the hash below for the license file but I did not see any others under the package directory
> so I think I must be misunderstanding where it should go from my reading of the on-line manual
> # Locally computed
> sha256 dcc100d4161cc0b7177545ab6e47216f84857cda3843847c792a25289852dcaa COPYING
> I ran ./utils/check-package package/udftools/* and fixed up all the white space errors
> But I'm not sure what to do with ./utils/test-pkg, do I need to build all 47 tools chains?
> I tried ./utils/test-pkg -p udftools -c udftools.snippet (contents below) but just got errors
> BR2_PACKAGE_UDFTOOLS=y
I've added a hash for the license file, and applied to next. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] udftools: new package
2018-02-06 16:08 ` Thomas Petazzoni
@ 2018-02-08 13:22 ` Marcus Folkesson
2018-02-08 14:20 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Marcus Folkesson @ 2018-02-08 13:22 UTC (permalink / raw)
To: buildroot
Thomas,
On Tue, Feb 06, 2018 at 05:08:06PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 22 Jan 2018 15:31:38 -0600, Steve Kenton wrote:
> > Signed-off-by: Steve Kenton <skenton@ou.edu>
> > ---
> > Try 2: fix stupid copy paste error in Config.in
> > Try 3: remove duplicate/misplaced addition to master Config.in
> > I wish I could see these issues when I first look the patch over - sigh
> > Try 4: Fixes for feedback from Thomas
> > I computed the hash below for the license file but I did not see any others under the package directory
> > so I think I must be misunderstanding where it should go from my reading of the on-line manual
> > # Locally computed
> > sha256 dcc100d4161cc0b7177545ab6e47216f84857cda3843847c792a25289852dcaa COPYING
> > I ran ./utils/check-package package/udftools/* and fixed up all the white space errors
> > But I'm not sure what to do with ./utils/test-pkg, do I need to build all 47 tools chains?
> > I tried ./utils/test-pkg -p udftools -c udftools.snippet (contents below) but just got errors
> > BR2_PACKAGE_UDFTOOLS=y
>
> I've added a hash for the license file, and applied to next. Thanks!
I think the license should be "GPL-2.0" ?
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180208/878c4a78/attachment.asc>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] udftools: new package
2018-02-08 13:22 ` Marcus Folkesson
@ 2018-02-08 14:20 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-02-08 14:20 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 8 Feb 2018 14:22:16 +0100, Marcus Folkesson wrote:
> > I've added a hash for the license file, and applied to next. Thanks!
>
> I think the license should be "GPL-2.0" ?
All the source files that have a license header have the mention:
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
So the license is GPL-2.0+.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-08 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-22 21:31 [Buildroot] [PATCH 1/1] udftools: new package Steve Kenton
2018-01-31 14:57 ` Marcus Folkesson
2018-02-06 16:08 ` Thomas Petazzoni
2018-02-08 13:22 ` Marcus Folkesson
2018-02-08 14:20 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox