From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Adding package libgit2
Date: Sun, 25 Feb 2018 22:27:53 +0100 [thread overview]
Message-ID: <20180225212753.GG2276@scaer> (raw)
In-Reply-To: <20180214163628.22360128@windsurf.lan>
Nicolas, Thomas, All,
On 2018-02-14 16:36 +0100, Thomas Petazzoni spake thusly:
> On Wed, 14 Feb 2018 16:30:24 +0100, Nicolas Cavallari wrote:
> > > ARCH is set to ${CMAKE_SYSTEM_PROCESSOR}, and CMAKE_SYSTEM_PROCESSOR is
> > > explicitly passed by Buildroot in package/pkg-cmake.mk. So it should be
> > > correct. zlib-ng CMakeLists.txt uses its ${ARCH} variable to decide
> > > whether the x86 code should be built or not:
> > >
> > > if("${ARCH}" MATCHES "x86_64" OR "${ARCH}" MATCHES "AMD64")
> > > set(ARCHDIR "arch/x86")
> > > add_definitions(-DX86_64 -DX86_NOCHECK_SSE2 -DUNALIGNED_OK -DUNROLL_LESS)
> > > add_feature_info(SSE2 1 "Use the SSE2 instruction set, using \"${SSE2FLAG}\"")
> >
> > I have added --trace to cmake. There is this gem a few lines below:
> >
> > else()
> > set(ARCHDIR "arch/x86")
> > add_definitions(-DX86 -DUNALIGNED_OK -DUNROLL_LESS)
> > add_feature_info(SSE2 1 "Support the SSE2 instruction set, using
> > \"${SSE2FLAG}\"")
> > endif()
> >
> > So anything not arm/aarch64/x86 is treated like x86 anyway...
>
> Which obviously is not going to work very well :)
>
> I guess this should be fixed and/or reported to zlib-ng upstream. In
> the mean time, either we fix it, or we disallow zlib-ng on
> architectures other than arm/aarch64/x86.
Yes, let's limit zlib-ng to the only arch upstream supports.
I'll send a patch...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2018-02-25 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:13 [Buildroot] Adding package libgit2 Nicolas Cavallari
2018-02-14 11:13 ` [Buildroot] [PATCH 1/1] libgit2: New package Nicolas Cavallari
2018-05-20 20:27 ` Thomas Petazzoni
2018-05-22 17:19 ` Nicolas Cavallari
2018-05-22 19:14 ` Thomas Petazzoni
2018-02-14 15:06 ` [Buildroot] Adding package libgit2 Thomas Petazzoni
2018-02-14 15:30 ` Nicolas Cavallari
2018-02-14 15:36 ` Thomas Petazzoni
2018-02-25 21:27 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225212753.GG2276@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox