From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libgit2: New package.
Date: Tue, 22 May 2018 21:14:55 +0200 [thread overview]
Message-ID: <20180522211455.1757a8b9@windsurf> (raw)
In-Reply-To: <6324c3b1-c745-7375-9535-0c46abb61974@green-communications.fr>
Hello,
On Tue, 22 May 2018 19:19:52 +0200, Nicolas Cavallari wrote:
> > So, I've applied to next, but I had to change quite a few things that
> > were not really correct:
> >
> > [Thomas:
> > - Do not select BR2_PACKAGE_ZLIB, because zlib is an optional
> > dependency.
> IIRC zlib is not really an optional dependency.? If zlib is not
> detected, then a bundled version of zlib is compiled in deps/zlib...
>
> I don't think this is desirable, that's why i forced a dependency on zlib.
OK, then indeed we want zlib to be a dependency. The thing is that you
had a select BR2_PACKAGE_ZLIB, but zlib was not in <pkg>_DEPENDENCIES.
Don't hesitate to send a follow-up patch re-introducing zlib as a
mandatory dependency.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-22 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:13 [Buildroot] Adding package libgit2 Nicolas Cavallari
2018-02-14 11:13 ` [Buildroot] [PATCH 1/1] libgit2: New package Nicolas Cavallari
2018-05-20 20:27 ` Thomas Petazzoni
2018-05-22 17:19 ` Nicolas Cavallari
2018-05-22 19:14 ` Thomas Petazzoni [this message]
2018-02-14 15:06 ` [Buildroot] Adding package libgit2 Thomas Petazzoni
2018-02-14 15:30 ` Nicolas Cavallari
2018-02-14 15:36 ` Thomas Petazzoni
2018-02-25 21:27 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522211455.1757a8b9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox