[Buildroot] [PATCH 1/2] Liblo : Disable werror

[Buildroot] [PATCH 1/2] Liblo : Disable werror

[Alex B]

From: Alex <alexbaldwinmusic@gmail.com>

Fixes :
http://autobuild.buildroot.net/results/61ab7e23d2ef62f055efc74a998e3c108a3cdb43

Signed-off-by: Alex <alexbaldwinmusic@gmail.com>
---
 package/liblo/liblo.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/liblo/liblo.mk b/package/liblo/liblo.mk
index 14b0527..c7d163d 100644
--- a/package/liblo/liblo.mk
+++ b/package/liblo/liblo.mk
@@ -12,6 +12,9 @@ LIBLO_LICENSE_FILES = COPYING
 LIBLO_INSTALL_STAGING = YES
 
 # IPv6 support broken, issue known upstream
-LIBLO_CONF_OPTS = --disable-ipv6
+# werror - not needed for release.
+LIBLO_CONF_OPTS += \
+	--disable-ipv6 \
+	--disable-werror
 
 $(eval $(autotools-package))
-- 
2.7.4

[Buildroot] [PATCH 2/2] Libo : Link libatomic

[Alex B]

From: Alex <alexbaldwinmusic@gmail.com>

Fixes :
http://autobuild.buildroot.net/results/c8b/c8bed3a3fa7d2b2258f573cbfcb01af07419e0bf/

Signed-off-by: Alex <alexbaldwinmusic@gmail.com>
---
 package/liblo/liblo.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/liblo/liblo.mk b/package/liblo/liblo.mk
index c7d163d..67cc02c 100644
--- a/package/liblo/liblo.mk
+++ b/package/liblo/liblo.mk
@@ -17,4 +17,10 @@ LIBLO_CONF_OPTS += \
 	--disable-ipv6 \
 	--disable-werror
 
+# Liblo uses atomics, so we need to link with
+# libatomic for the architectures who explicitly need libatomic.
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+	LIBLO_CONF_ENV += LIBS="-latomic"
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

[Buildroot] [PATCH 1/2] Liblo : Disable werror

[Alex B]

From: Alex <alexbaldwinmusic@gmail.com>

Fixes :
http://autobuild.buildroot.net/results/61ab7e23d2ef62f055efc74a998e3c108a3cdb43

Signed-off-by: Alex Baldwin <alexbaldwinmusic@gmail.com>
---
 package/liblo/liblo.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/liblo/liblo.mk b/package/liblo/liblo.mk
index 14b0527..c7d163d 100644
--- a/package/liblo/liblo.mk
+++ b/package/liblo/liblo.mk
@@ -12,6 +12,9 @@ LIBLO_LICENSE_FILES = COPYING
 LIBLO_INSTALL_STAGING = YES
 
 # IPv6 support broken, issue known upstream
-LIBLO_CONF_OPTS = --disable-ipv6
+# werror - not needed for release.
+LIBLO_CONF_OPTS += \
+	--disable-ipv6 \
+	--disable-werror
 
 $(eval $(autotools-package))
-- 
2.7.4

[Buildroot] [PATCH 1/2] Liblo : Disable werror

[Thomas Petazzoni]

Hello,

On Sun, 25 Feb 2018 15:40:33 +0100, Alex B wrote:
> From: Alex <alexbaldwinmusic@gmail.com>
> 
> Fixes :
> http://autobuild.buildroot.net/results/61ab7e23d2ef62f055efc74a998e3c108a3cdb43
> 
> Signed-off-by: Alex <alexbaldwinmusic@gmail.com>

I've applied your two patches to next, after fixing a number of minor
nits:

 - The commit title should be "<package>: <description>", with package
   in lower-case, and no space before the colon.

 - The author and Signed-off-by should have been your full first name +
   last name, like you did for your previous contributions.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com