[Buildroot] [PATCH 1/1] apache sbindir

[Buildroot] [PATCH 1/1] apache sbindir

[Christopher McCrory]

The apache configure script help indicates that the sbindir is PREFIX/sbin , but it actually uses PREFIX/bin. I suspect most people would expect httpd to be /usr/sbin/httpd , not /usr/bin/httpd.

Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 package/apache/apache.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/apache/apache.mk b/package/apache/apache.mk
index e1b1a209cb..010ec31c33 100644
--- a/package/apache/apache.mk
+++ b/package/apache/apache.mk
@@ -29,6 +29,7 @@ APACHE_MPM = worker
 endif
 
 APACHE_CONF_OPTS = \
+	--sbindir=/usr/sbin \
 	--sysconfdir=/etc/apache2 \
 	--with-apr=$(STAGING_DIR)/usr \
 	--with-apr-util=$(STAGING_DIR)/usr \
-- 
2.14.3

[Buildroot] [PATCH 1/1] apache sbindir

[Thomas Petazzoni]

Hello,

The commit title should be:

	apache: pass explicit sbindir

On Tue, 27 Feb 2018 03:40:33 -0800, Christopher McCrory wrote:

> The apache configure script help indicates that the sbindir is PREFIX/sbin , but it actually uses PREFIX/bin. I suspect most people would expect httpd to be /usr/sbin/httpd , not /usr/bin/httpd.

This needs to be wrapped at 72 characters. Also, it's good avoid first
person sentences. So instead of "I suspect" you could say: "Most people
probably expect httpd to be located in /usr/sbin/httpd".

> diff --git a/package/apache/apache.mk b/package/apache/apache.mk
> index e1b1a209cb..010ec31c33 100644
> --- a/package/apache/apache.mk
> +++ b/package/apache/apache.mk
> @@ -29,6 +29,7 @@ APACHE_MPM = worker
>  endif
>  
>  APACHE_CONF_OPTS = \
> +	--sbindir=/usr/sbin \

Perhaps a quick comment would be appropriate above APACHE_CONF_OPTS,
like:

# Explicitly pass sbindir, because apache configure script defines it
# to PREFIX/bin, which doesn't make much sense

Or something like that.

Could you respin an updated version ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com