* [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges
@ 2018-03-08 14:25 Anssi Hannula
2018-03-08 16:27 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Anssi Hannula @ 2018-03-08 14:25 UTC (permalink / raw)
To: buildroot
systemd meson.build uses values from host /etc/login.defs if
system-uid-max and system-gid-max build options are not explicitly
specified.
Avoid that by setting system-uid-max and system-gid-max to 999 which is
the systemd default if SYSTEM_UID_MAX and SYSTEM_GID_MAX are not set in
/etc/login.defs.
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
---
package/systemd/systemd.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 8c22c08..3bc322c 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -40,6 +40,8 @@ SYSTEMD_CONF_OPTS += \
-Dldconfig=false \
-Ddefault-dnssec=no \
-Dtests=false \
+ -Dsystem-uid-max=999 \
+ -Dsystem-gid-max=999 \
-Dtelinit-path=$(TARGET_DIR)/sbin/telinit \
-Dkill-path=/usr/bin/kill \
-Dkmod-path=/usr/bin/kmod \
--
2.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges
2018-03-08 14:25 [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges Anssi Hannula
@ 2018-03-08 16:27 ` Yann E. MORIN
2018-03-09 8:15 ` Anssi Hannula
2018-03-09 21:35 ` Peter Korsgaard
2018-04-07 15:39 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2018-03-08 16:27 UTC (permalink / raw)
To: buildroot
Anssi, All,
On 2018-03-08 16:25 +0200, Anssi Hannula spake thusly:
> systemd meson.build uses values from host /etc/login.defs if
> system-uid-max and system-gid-max build options are not explicitly
> specified.
>
> Avoid that by setting system-uid-max and system-gid-max to 999 which is
> the systemd default if SYSTEM_UID_MAX and SYSTEM_GID_MAX are not set in
> /etc/login.defs.
>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Would we need to do something with dynamic-uid-min, dynamic-uid-max, and
so on?
Regards,
Yann E. MORIN.
> ---
> package/systemd/systemd.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 8c22c08..3bc322c 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -40,6 +40,8 @@ SYSTEMD_CONF_OPTS += \
> -Dldconfig=false \
> -Ddefault-dnssec=no \
> -Dtests=false \
> + -Dsystem-uid-max=999 \
> + -Dsystem-gid-max=999 \
> -Dtelinit-path=$(TARGET_DIR)/sbin/telinit \
> -Dkill-path=/usr/bin/kill \
> -Dkmod-path=/usr/bin/kmod \
> --
> 2.8.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges
2018-03-08 16:27 ` Yann E. MORIN
@ 2018-03-09 8:15 ` Anssi Hannula
0 siblings, 0 replies; 5+ messages in thread
From: Anssi Hannula @ 2018-03-09 8:15 UTC (permalink / raw)
To: buildroot
On 8.3.2018 18:27, Yann E. MORIN wrote:
> Anssi, All,
>
> On 2018-03-08 16:25 +0200, Anssi Hannula spake thusly:
>> systemd meson.build uses values from host /etc/login.defs if
>> system-uid-max and system-gid-max build options are not explicitly
>> specified.
>>
>> Avoid that by setting system-uid-max and system-gid-max to 999 which is
>> the systemd default if SYSTEM_UID_MAX and SYSTEM_GID_MAX are not set in
>> /etc/login.defs.
>>
>> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Would we need to do something with dynamic-uid-min, dynamic-uid-max, and
> so on?
I don't think so, for the other uid/gid options the defaults seemed sane
and did not depend on the host system.
>> ---
>> package/systemd/systemd.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
>> index 8c22c08..3bc322c 100644
>> --- a/package/systemd/systemd.mk
>> +++ b/package/systemd/systemd.mk
>> @@ -40,6 +40,8 @@ SYSTEMD_CONF_OPTS += \
>> -Dldconfig=false \
>> -Ddefault-dnssec=no \
>> -Dtests=false \
>> + -Dsystem-uid-max=999 \
>> + -Dsystem-gid-max=999 \
>> -Dtelinit-path=$(TARGET_DIR)/sbin/telinit \
>> -Dkill-path=/usr/bin/kill \
>> -Dkmod-path=/usr/bin/kmod \
>> --
>> 2.8.3
>>
--
Anssi Hannula / Bitwise Oy
+358503803997
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges
2018-03-08 14:25 [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges Anssi Hannula
2018-03-08 16:27 ` Yann E. MORIN
@ 2018-03-09 21:35 ` Peter Korsgaard
2018-04-07 15:39 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-03-09 21:35 UTC (permalink / raw)
To: buildroot
>>>>> "Anssi" == Anssi Hannula <anssi.hannula@bitwise.fi> writes:
> systemd meson.build uses values from host /etc/login.defs if
> system-uid-max and system-gid-max build options are not explicitly
> specified.
> Avoid that by setting system-uid-max and system-gid-max to 999 which is
> the systemd default if SYSTEM_UID_MAX and SYSTEM_GID_MAX are not set in
> /etc/login.defs.
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges
2018-03-08 14:25 [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges Anssi Hannula
2018-03-08 16:27 ` Yann E. MORIN
2018-03-09 21:35 ` Peter Korsgaard
@ 2018-04-07 15:39 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-04-07 15:39 UTC (permalink / raw)
To: buildroot
>>>>> "Anssi" == Anssi Hannula <anssi.hannula@bitwise.fi> writes:
> systemd meson.build uses values from host /etc/login.defs if
> system-uid-max and system-gid-max build options are not explicitly
> specified.
> Avoid that by setting system-uid-max and system-gid-max to 999 which is
> the systemd default if SYSTEM_UID_MAX and SYSTEM_GID_MAX are not set in
> /etc/login.defs.
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-07 15:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08 14:25 [Buildroot] [PATCH] systemd: do not use host system-uid/gid ranges Anssi Hannula
2018-03-08 16:27 ` Yann E. MORIN
2018-03-09 8:15 ` Anssi Hannula
2018-03-09 21:35 ` Peter Korsgaard
2018-04-07 15:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox