* [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
@ 2018-03-19 10:55 Phil Eichinger
2018-03-19 17:04 ` Peter Seiderer
2018-10-20 19:00 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Phil Eichinger @ 2018-03-19 10:55 UTC (permalink / raw)
To: buildroot
qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported
yet. So compiling with Qt5 which has only GLES enabled fails.
https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5
Signed-off-by: Phil Eichinger <phil@zankapfel.net>
---
package/libv4l/libv4l.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index 11061306c7..5eb26ee16c 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -51,7 +51,7 @@ endif
ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
LIBV4L_CONF_OPTS += --enable-v4l-utils
LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
-ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
+ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)
LIBV4L_CONF_OPTS += --enable-qv4l2
LIBV4L_DEPENDENCIES += qt5base
# protect against host version detection of moc-qt5/rcc-qt5/uic-qt5
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
2018-03-19 10:55 [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES Phil Eichinger
@ 2018-03-19 17:04 ` Peter Seiderer
2018-03-20 8:41 ` phil eichinger
2018-10-20 19:00 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2018-03-19 17:04 UTC (permalink / raw)
To: buildroot
Hello Phil,
On Mon, 19 Mar 2018 11:55:31 +0100, Phil Eichinger <phil@zankapfel.net> wrote:
> qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported
> yet. So compiling with Qt5 which has only GLES enabled fails.
>
> https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---
> package/libv4l/libv4l.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
> index 11061306c7..5eb26ee16c 100644
> --- a/package/libv4l/libv4l.mk
> +++ b/package/libv4l/libv4l.mk
> @@ -51,7 +51,7 @@ endif
> ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
> LIBV4L_CONF_OPTS += --enable-v4l-utils
> LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
> -ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
> +ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)
NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h
HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...
Do your have a (minimal) buildroot defconfig which failes to build libv4l?
Regards,
Peter
> LIBV4L_CONF_OPTS += --enable-qv4l2
> LIBV4L_DEPENDENCIES += qt5base
> # protect against host version detection of moc-qt5/rcc-qt5/uic-qt5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
2018-03-19 17:04 ` Peter Seiderer
@ 2018-03-20 8:41 ` phil eichinger
2018-03-20 9:42 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: phil eichinger @ 2018-03-20 8:41 UTC (permalink / raw)
To: buildroot
On Mon, Mar 19, 2018 at 06:04:50PM +0100, Peter Seiderer wrote:
> Hello Phil,
>
> On Mon, 19 Mar 2018 11:55:31 +0100, Phil Eichinger <phil@zankapfel.net> wrote:
>
> > qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported
> > yet. So compiling with Qt5 which has only GLES enabled fails.
> >
> > https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5
> > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> > ---
> > package/libv4l/libv4l.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
> > index 11061306c7..5eb26ee16c 100644
> > --- a/package/libv4l/libv4l.mk
> > +++ b/package/libv4l/libv4l.mk
> > @@ -51,7 +51,7 @@ endif
> > ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
> > LIBV4L_CONF_OPTS += --enable-v4l-utils
> > LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
> > -ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
> > +ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)
>
> NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h
> HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...
Oh, that was a misunderstanding on my part, I haven't taken non-GL
builds into account. I only need to disable it if BR2_PACKAGE_QT5BASE_OPENGL_ES2 is enabled.
Because then it gets built with HAVE_QTGL which won't work.
I'll come up with a v2 then.
Regards
Phil
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
2018-03-20 8:41 ` phil eichinger
@ 2018-03-20 9:42 ` Peter Seiderer
0 siblings, 0 replies; 5+ messages in thread
From: Peter Seiderer @ 2018-03-20 9:42 UTC (permalink / raw)
To: buildroot
Hello Phil,
> Gesendet: Dienstag, 20. M?rz 2018 um 09:41 Uhr
> Von: "phil eichinger" <phil@zankapfel.net>
> An: "Peter Seiderer" <ps.report@gmx.net>
> Cc: buildroot at buildroot.org
> Betreff: Re: [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
>
> On Mon, Mar 19, 2018 at 06:04:50PM +0100, Peter Seiderer wrote:
> > Hello Phil,
> >
> > On Mon, 19 Mar 2018 11:55:31 +0100, Phil Eichinger <phil@zankapfel.net> wrote:
> >
> > > qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported
> > > yet. So compiling with Qt5 which has only GLES enabled fails.
> > >
> > > https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5
> > > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> > > ---
> > > package/libv4l/libv4l.mk | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
> > > index 11061306c7..5eb26ee16c 100644
> > > --- a/package/libv4l/libv4l.mk
> > > +++ b/package/libv4l/libv4l.mk
> > > @@ -51,7 +51,7 @@ endif
> > > ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
> > > LIBV4L_CONF_OPTS += --enable-v4l-utils
> > > LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
> > > -ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
> > > +ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)
> >
> > NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h
> > HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...
>
> Oh, that was a misunderstanding on my part, I haven't taken non-GL
> builds into account. I only need to disable it if BR2_PACKAGE_QT5BASE_OPENGL_ES2 is enabled.
> Because then it gets built with HAVE_QTGL which won't work.
> I'll come up with a v2 then.
It depends, I have a IMX.6/etnaviv config, BR2_PACKAGE_QT5BASE_OPENGL_ES2 enabled, no compile
problems (but HAVE_QTGL is disabled), maybe it is possible to do some fine tuning with
the build/libv4l-1.14.1/configure.ac logic?
Can you provide your defconfig?
Regards,
Peter
>
> Regards
>
> Phil
> --
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES
2018-03-19 10:55 [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES Phil Eichinger
2018-03-19 17:04 ` Peter Seiderer
@ 2018-10-20 19:00 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-10-20 19:00 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 19 Mar 2018 11:55:31 +0100, Phil Eichinger wrote:
> qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported
> yet. So compiling with Qt5 which has only GLES enabled fails.
>
> https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---
> package/libv4l/libv4l.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Following the feedback from Peter Seiderer, I've marked this patch as
Rejected in patchwork. We also don't have build failures that match
this issue it seems.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-20 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-19 10:55 [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES Phil Eichinger
2018-03-19 17:04 ` Peter Seiderer
2018-03-20 8:41 ` phil eichinger
2018-03-20 9:42 ` Peter Seiderer
2018-10-20 19:00 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox