From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 7/9] package/pkg-generic: handle host-ccache as a regular dependency
Date: Sat, 24 Mar 2018 15:20:06 +0100 [thread overview]
Message-ID: <20180324142008.10375-8-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20180324142008.10375-1-thomas.petazzoni@bootlin.com>
This moves the host-ccache dependency handling from
DEPENDENCIES_HOST_PREREQ to a proper package dependency. When
BR2_CCACHE=y, we add host-ccache as a regular dependency of all
packages except:
- The extractor packages host-tar, host-xz and host-lzip
- host-ccache itself
- host-skeleton, because all packages depend on it
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
Changes since v3:
- Prevent host-ccache from being a dependency of itself, as noticed
by Yann.
Changes since v2:
- New patch
---
package/ccache/ccache.mk | 5 +++++
package/pkg-generic.mk | 6 ++++++
support/dependencies/dependencies.mk | 4 ----
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk
index 552a611f42..9a11d46d30 100644
--- a/package/ccache/ccache.mk
+++ b/package/ccache/ccache.mk
@@ -21,6 +21,11 @@ CCACHE_LICENSE_FILES = LICENSE.txt GPL-3.0.txt
# has zero dependency besides the C library.
HOST_CCACHE_CONF_OPTS += --with-bundled-zlib
+# We are ccache, so we can't use ccache
+HOST_CCACHE_CONF_ENV = \
+ CC="$(HOSTCC_NOCCACHE)" \
+ CXX="$(HOSTCXX_NOCCACHE)"
+
# Patch host-ccache as follows:
# - Use BR_CACHE_DIR instead of CCACHE_DIR, because CCACHE_DIR
# is already used by autotargets for the ccache package.
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index f03f1d930f..bc4882235f 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -567,6 +567,12 @@ ifeq ($(filter host-tar host-skeleton host-xz host-lzip,$(1)),)
$(2)_EXTRACT_DEPENDENCIES += $(BR2_LZIP_HOST_DEPENDENCY)
endif
+ifeq ($(BR2_CCACHE),y)
+ifeq ($(filter host-tar host-skeleton host-xz host-lzip host-ccache,$(1)),)
+$(2)_DEPENDENCIES += host-ccache
+endif
+endif
+
# Eliminate duplicates in dependencies
$(2)_FINAL_DEPENDENCIES = $$(sort $$($(2)_DEPENDENCIES))
$(2)_FINAL_EXTRACT_DEPENDENCIES = $$(sort $$($(2)_EXTRACT_DEPENDENCIES))
diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk
index 3fc235863c..bab064319f 100644
--- a/support/dependencies/dependencies.mk
+++ b/support/dependencies/dependencies.mk
@@ -17,10 +17,6 @@ endef
include support/dependencies/check-host-tar.mk
-include $(sort $(filter-out %-tar.mk,$(wildcard support/dependencies/check-host-*.mk)))
-ifeq ($(BR2_CCACHE),y)
-DEPENDENCIES_HOST_PREREQ += host-ccache
-endif
-
core-dependencies:
@MAKE="$(MAKE)" DL_TOOLS="$(sort $(DL_TOOLS_DEPENDENCIES))" \
$(TOPDIR)/support/dependencies/dependencies.sh
--
2.14.3
next prev parent reply other threads:[~2018-03-24 14:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 14:19 [Buildroot] [PATCH v4 0/9] Preparation for per-package host/target directories Thomas Petazzoni
2018-03-24 14:20 ` [Buildroot] [PATCH v4 1/9] Makefile, skeleton: move the host skeleton logic to host-skeleton package Thomas Petazzoni
2018-03-24 15:28 ` Yann E. MORIN
2018-03-24 15:37 ` Thomas Petazzoni
2018-03-24 15:43 ` Yann E. MORIN
2018-03-25 13:00 ` Peter Korsgaard
2018-03-25 13:21 ` Yann E. MORIN
2018-03-25 15:34 ` Peter Korsgaard
2018-03-25 14:59 ` Thomas Petazzoni
2018-03-25 15:33 ` Peter Korsgaard
2018-03-25 15:36 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 2/9] pkg-cmake: install CMake files as part of a package Thomas Petazzoni
2018-03-25 15:37 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 3/9] package/pkg-generic: add the concept of extract dependency Thomas Petazzoni
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:40 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 4/9] package/pkg-generic: handle host-tar as an " Thomas Petazzoni
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:42 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 5/9] package/pkg-generic: handle host-xz " Thomas Petazzoni
2018-03-25 15:45 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 6/9] package/pkg-generic: handle host-lzip " Thomas Petazzoni
2018-03-25 15:48 ` Peter Korsgaard
2018-03-24 14:20 ` Thomas Petazzoni [this message]
2018-03-24 15:38 ` [Buildroot] [PATCH v4 7/9] package/pkg-generic: handle host-ccache as a regular dependency Yann E. MORIN
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:50 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 8/9] package/pkg-generic: handle host-fakedate " Thomas Petazzoni
2018-03-25 15:51 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 9/9] core: kill DEPENDENCIES_HOST_PREREQ Thomas Petazzoni
2018-03-25 15:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324142008.10375-8-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox