From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/9] Makefile, skeleton: move the host skeleton logic to host-skeleton package
Date: Sat, 24 Mar 2018 16:37:16 +0100 [thread overview]
Message-ID: <20180324163716.1818c77e@windsurf> (raw)
In-Reply-To: <20180324152852.GA2620@scaer>
Hello,
On Sat, 24 Mar 2018 16:28:52 +0100, Yann E. MORIN wrote:
> > +ifneq ($(1),host-skeleton)
> > +$(2)_DEPENDENCIES += host-skeleton
> > +endif
>
> In fact, I'm not too sure I should have given my Reviewed-by tag,
> because now the graph-depends are all borked: all packages have a
> dependency arrow toward host-skeleton.
It is not borked, that's completely correct. Maybe not pretty and
convenient, but definitely not "borked".
> What about adding host-skeleton as a dependency to skeleton-init-common
> and skeleton-custom only?
Really feels wrong to me: there is absolutely no reason for
skeleton-init-common and skeleton-custom to depend on host-skeleton.
> Or we can also just add host-skeleton as a special case in
> support/scripts/graph-depends...
That feels like a much better solution to me. We already do that for
the skeleton anyway. Would that be OK for you?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-24 15:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 14:19 [Buildroot] [PATCH v4 0/9] Preparation for per-package host/target directories Thomas Petazzoni
2018-03-24 14:20 ` [Buildroot] [PATCH v4 1/9] Makefile, skeleton: move the host skeleton logic to host-skeleton package Thomas Petazzoni
2018-03-24 15:28 ` Yann E. MORIN
2018-03-24 15:37 ` Thomas Petazzoni [this message]
2018-03-24 15:43 ` Yann E. MORIN
2018-03-25 13:00 ` Peter Korsgaard
2018-03-25 13:21 ` Yann E. MORIN
2018-03-25 15:34 ` Peter Korsgaard
2018-03-25 14:59 ` Thomas Petazzoni
2018-03-25 15:33 ` Peter Korsgaard
2018-03-25 15:36 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 2/9] pkg-cmake: install CMake files as part of a package Thomas Petazzoni
2018-03-25 15:37 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 3/9] package/pkg-generic: add the concept of extract dependency Thomas Petazzoni
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:40 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 4/9] package/pkg-generic: handle host-tar as an " Thomas Petazzoni
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:42 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 5/9] package/pkg-generic: handle host-xz " Thomas Petazzoni
2018-03-25 15:45 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 6/9] package/pkg-generic: handle host-lzip " Thomas Petazzoni
2018-03-25 15:48 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 7/9] package/pkg-generic: handle host-ccache as a regular dependency Thomas Petazzoni
2018-03-24 15:38 ` Yann E. MORIN
2018-03-25 3:23 ` Matthew Weber
2018-03-25 15:50 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 8/9] package/pkg-generic: handle host-fakedate " Thomas Petazzoni
2018-03-25 15:51 ` Peter Korsgaard
2018-03-24 14:20 ` [Buildroot] [PATCH v4 9/9] core: kill DEPENDENCIES_HOST_PREREQ Thomas Petazzoni
2018-03-25 15:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324163716.1818c77e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox