* [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$'.
@ 2018-03-07 9:48 Nicolas Cavallari
2018-03-07 15:48 ` Ricardo Martincoski
2018-03-31 21:03 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Cavallari @ 2018-03-07 9:48 UTC (permalink / raw)
To: buildroot
check-package would flag tabs before a backslash ('\t\\'),
two spaces before a backslash (' \\') but would not flag a tab before space
before backslash ('\t \\'), allowing someone to bypass the check.
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
There is no occurence of this in buildroot.
utils/checkpackagelib/lib_mk.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py
index 2df2e1a884..cfd4d05117 100644
--- a/utils/checkpackagelib/lib_mk.py
+++ b/utils/checkpackagelib/lib_mk.py
@@ -123,7 +123,7 @@ class RemoveDefaultPackageSourceVariable(_CheckFunction):
class SpaceBeforeBackslash(_CheckFunction):
- TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t)\\$")
+ TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t ?)\\$")
def check_line(self, lineno, text):
if self.TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH.match(text.rstrip()):
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$'.
2018-03-07 9:48 [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$' Nicolas Cavallari
@ 2018-03-07 15:48 ` Ricardo Martincoski
2018-03-31 21:03 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Martincoski @ 2018-03-07 15:48 UTC (permalink / raw)
To: buildroot
Hello,
> check-package would flag tabs before a backslash ('\t\\'),
> two spaces before a backslash (' \\') but would not flag a tab before space
> before backslash ('\t \\'), allowing someone to bypass the check.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Reviewed-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Regards,
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$'.
2018-03-07 9:48 [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$' Nicolas Cavallari
2018-03-07 15:48 ` Ricardo Martincoski
@ 2018-03-31 21:03 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-03-31 21:03 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 7 Mar 2018 10:48:12 +0100, Nicolas Cavallari wrote:
> check-package would flag tabs before a backslash ('\t\\'),
> two spaces before a backslash (' \\') but would not flag a tab before space
> before backslash ('\t \\'), allowing someone to bypass the check.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
>
> ---
> There is no occurence of this in buildroot.
> utils/checkpackagelib/lib_mk.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-31 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-07 9:48 [Buildroot] [PATCH 1/1] check-package: Flag usage of '\t \\$' Nicolas Cavallari
2018-03-07 15:48 ` Ricardo Martincoski
2018-03-31 21:03 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox