Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/apache: fix lua detection
@ 2018-04-01 12:26 Bernd Kuhls
  2018-04-01 14:23 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2018-04-01 12:26 UTC (permalink / raw)
  To: buildroot

Patch suggested by Thomas: Adding a path to --with-lua disables
pkgconf-based detection of lua, which in some cases needs libdl.

This patch removes --with-lua which fixes
http://autobuild.buildroot.net/results/cc1/cc13f4cef9cf6f18615d58f1d83b233812f19fa0/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: rely on pkgconf (Thomas)

 package/apache/apache.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/package/apache/apache.mk b/package/apache/apache.mk
index 3b39be4a40..23414fe44d 100644
--- a/package/apache/apache.mk
+++ b/package/apache/apache.mk
@@ -57,9 +57,7 @@ APACHE_CONF_OPTS += \
 endif
 
 ifeq ($(BR2_PACKAGE_LUA),y)
-APACHE_CONF_OPTS += \
-	--enable-lua \
-	--with-lua=$(STAGING_DIR)/usr
+APACHE_CONF_OPTS += --enable-lua
 APACHE_DEPENDENCIES += lua
 else
 APACHE_CONF_OPTS += --disable-lua
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2 1/1] package/apache: fix lua detection
  2018-04-01 12:26 [Buildroot] [PATCH v2 1/1] package/apache: fix lua detection Bernd Kuhls
@ 2018-04-01 14:23 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-04-01 14:23 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  1 Apr 2018 14:26:40 +0200, Bernd Kuhls wrote:
> Patch suggested by Thomas: Adding a path to --with-lua disables
> pkgconf-based detection of lua, which in some cases needs libdl.
> 
> This patch removes --with-lua which fixes
> http://autobuild.buildroot.net/results/cc1/cc13f4cef9cf6f18615d58f1d83b233812f19fa0/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: rely on pkgconf (Thomas)

Ah, see how this solution is much simpler and logical? Thanks for
checking that it was indeed working. Applied!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-01 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-01 12:26 [Buildroot] [PATCH v2 1/1] package/apache: fix lua detection Bernd Kuhls
2018-04-01 14:23 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox