Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: bump to 1.14.0
Date: Tue, 10 Apr 2018 23:40:19 +0200	[thread overview]
Message-ID: <20180410234019.2fc5516d@windsurf> (raw)
In-Reply-To: <20180410182813.691be3ff@gmx.net>

Hello Peter,

Thanks for your feedback!

On Tue, 10 Apr 2018 18:28:13 +0200, Peter Seiderer wrote:

> > Indeed, the gst1-plugins-bad package still has a
> > --enable-wayland/--disable-wayland option:
> > 
> > output/build/gst1-plugins-bad-1.14.0 $ ./configure --help | grep wayland
> >   --disable-wayland            disable wayland sink: wayland  
> 
> This is the 'old' one in gstreamer and buildroot and should be kept (NOT moved from bad to base)....

Not sure to understand what you say here. Do you say: "This option
already exists in the current version of GStreamer packaged by
Buildroot, and continues to exist in 1.14.0 and therefore should be
kept in Buildroot, i.e BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
should stay.

Is that what you meant ?

> > And in base:
> > 
> > output/build/gst1-plugins-base-1.14.0 $ ./configure --help | grep wayland
> >   --enable-wayland        Enable Wayland support (requires EGL) [default=auto]  
> 
> This is the 'new' one in gstreamer, yet without handling in buildroot, enables
> wayland support in libgstgl (which is used by some plugins, but I believe not
> by the waylandsink plugin from bad)...

For this one, do you think we need an explicit
BR2_PACKAGE_GST1_PLUGINS_BASE_WAYLAND option, or should we just pass
--enable-wayland as soon as Wayland+EGL are available, in
gst1-plugins-base.mk ?


> > In gst1-plugins-base, the --enable-wayland option requires EGL support,
> > and will enable some wayland related code in gst-libs/gl/. Peter, do
> > you understand what this does, compared to the wayland sink provided in
> > gst1-plugins-bad ?  
> 
> Yes, your short analysis is right (and sorry, I can add no more details what
> is enabled/disabled in the resulting libgstgl library)....

You *can* add more details, or you *can't* ? :-)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-10 21:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 17:32 [Buildroot] [PATCH v4 1/8] gstreamer1: bump to 1.14.0 Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: " Adam Duskett
2018-03-22 22:55   ` Peter Seiderer
2018-03-28  9:07     ` Martin Kepplinger
2018-04-10  8:07     ` Thomas Petazzoni
2018-04-10 16:28       ` Peter Seiderer
2018-04-10 21:40         ` Thomas Petazzoni [this message]
2018-04-11  6:56           ` Peter Seiderer
2018-04-11  9:35             ` Thomas Petazzoni
2018-04-12 13:41               ` Adam Duskett
2018-04-12 19:21                 ` Peter Seiderer
2018-04-10  8:08   ` Thomas Petazzoni
2018-03-22 17:32 ` [Buildroot] [PATCH v4 3/8] gst-omx: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 4/8] gst1-rtsp-server: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 5/8] gst1-vaapi: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 6/8] gst1-libav: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 7/8] gst1-validate: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 8/8] gst1-imx: add hash for license file Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410234019.2fc5516d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox