From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: bump to 1.14.0
Date: Thu, 12 Apr 2018 21:21:55 +0200 [thread overview]
Message-ID: <20180412212155.2ef3f288@gmx.net> (raw)
In-Reply-To: <CAFSsvmpedras9GU7sLqMn_a=w4vWi1HpcV20=7QyF1pTKAmhCw@mail.gmail.com>
Hello Adam, Thomas,
On Thu, 12 Apr 2018 09:41:31 -0400, Adam Duskett <aduskett@gmail.com> wrote:
> All;
>
> On Wed, Apr 11, 2018 at 5:35 AM, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > Hello,
> >
> > On Wed, 11 Apr 2018 08:56:56 +0200, Peter Seiderer wrote:
> >
> >> > Not sure to understand what you say here. Do you say: "This option
> >> > already exists in the current version of GStreamer packaged by
> >> > Buildroot, and continues to exist in 1.14.0 and therefore should be
> >> > kept in Buildroot, i.e BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
> >> > should stay.
> >>
> >> I think the BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND could/should
> >> move to base, but the waylandsink enabling BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND
> >> should stay in bad....(maybe the confusion comes from the double use of
> >> --enable-wayland option in gst1-plugins-bad enabling wayland support in
> >> libGstGl and/or enabling the waylandsink element)...
> >>
> >> From package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk:
> >>
> >> ifneq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND)$(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND),)
> >> GST1_PLUGINS_BAD_CONF_OPTS += --enable-wayland
> >> GST1_PLUGINS_BAD_DEPENDENCIES += wayland wayland-protocols
> >> else
> >> GST1_PLUGINS_BAD_CONF_OPTS += --disable-wayland
> >> endif
> >>
> >>
> >> From package/gstreamer1/gst1-plugins-bad/Config.in:
> >>
> >> config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
> >> bool "wayland"
> >> default y
> >> depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL
> >> depends on BR2_PACKAGE_WAYLAND
> >> select BR2_PACKAGE_WAYLAND_PROTOCOLS
> >> select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
> >> [...]
> >> config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND
> >> bool "wayland"
> >> default y
> >> depends on BR2_PACKAGE_WAYLAND
> >> select BR2_PACKAGE_WAYLAND_PROTOCOLS
> >> help
> >> Wayland Video Sink
> >>
> >> I get a running waylandsink with:
> >>
> >> # BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_WAYLAND is not set
> >> BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND=y
> >
> > Still not sure to fully understand what you're proposing. Do you think
> > you could take over this series, make the changes that you think are
> > necessary and resubmit ? This would be useful to help the discussion
> > move forward.
> >
> > Thanks!
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> I agre with Thomas here. I would really appreciate either exactly what
> you had in
> mind, or I could add what you want if you send me exactly what you
> were thinking.
Will try to prepare a draft patch version....
Regards,
Peter
>
> Thanks!
>
> Adam
next prev parent reply other threads:[~2018-04-12 19:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 17:32 [Buildroot] [PATCH v4 1/8] gstreamer1: bump to 1.14.0 Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: " Adam Duskett
2018-03-22 22:55 ` Peter Seiderer
2018-03-28 9:07 ` Martin Kepplinger
2018-04-10 8:07 ` Thomas Petazzoni
2018-04-10 16:28 ` Peter Seiderer
2018-04-10 21:40 ` Thomas Petazzoni
2018-04-11 6:56 ` Peter Seiderer
2018-04-11 9:35 ` Thomas Petazzoni
2018-04-12 13:41 ` Adam Duskett
2018-04-12 19:21 ` Peter Seiderer [this message]
2018-04-10 8:08 ` Thomas Petazzoni
2018-03-22 17:32 ` [Buildroot] [PATCH v4 3/8] gst-omx: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 4/8] gst1-rtsp-server: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 5/8] gst1-vaapi: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 6/8] gst1-libav: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 7/8] gst1-validate: " Adam Duskett
2018-03-22 17:32 ` [Buildroot] [PATCH v4 8/8] gst1-imx: add hash for license file Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412212155.2ef3f288@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox