From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d
Date: Thu, 12 Apr 2018 13:38:05 +0200 [thread overview]
Message-ID: <20180412133805.5f97f451@windsurf> (raw)
In-Reply-To: <20180411212741.16489-1-andre@ignavus.net>
Hello Andre,
Thanks for this new version, this is almost good, but not yet :)
On Thu, 12 Apr 2018 09:27:41 +1200, Andre Renaud wrote:
> From: Andre Renaud <arenaud@designa-electronics.com>
>
Your Signed-off-by line is missing here, could you resend with this
Signed-off-by line added ?
Also, please change the commit title to:
mesa3d: add option to enable Freedreno gallium driver
Indeed:
- We also want the commit log to have the format "<package>:
<description>"
- Using a past tense "Added" doesn't make a lot of sense. Your commit
has not "added" something, it is adding something. So using just
"add" makes a lot more sense
Could you resend after fixing those minor issues? I had fixed myself
the commit title issue and was about to push your patch, but the
missing Signed-off-by requires you to resend a new version.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-04-12 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 21:27 [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d Andre Renaud
2018-04-12 11:38 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412133805.5f97f451@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox