[Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d

[Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d

[Andre Renaud]

From: Andre Renaud <arenaud@designa-electronics.com>

---
 package/mesa3d/Config.in | 7 +++++++
 package/mesa3d/mesa3d.mk | 1 +
 2 files changed, 8 insertions(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 1476b39acc..5005c98cee 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -85,6 +85,13 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
 	help
 	  Mesa driver for Vivante GPUs.
 
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
+	bool "Gallium freedreno driver"
+	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_FREEDRENO
+	help
+	  Mesa driver for Freedreno GPUs.
+
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
 	bool "Gallium nouveau driver"
 	depends on BR2_i386 || BR2_x86_64
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index 506f84274f..bf177591c7 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -78,6 +78,7 @@ endif
 
 #Gallium Drivers
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV)  += etnaviv imx
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO)  += freedreno
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)  += nouveau
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)     += r600
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA)     += svga
-- 
2.15.1

[Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d

[Thomas Petazzoni]

Hello Andre,

Thanks for this new version, this is almost good, but not yet :)

On Thu, 12 Apr 2018 09:27:41 +1200, Andre Renaud wrote:
> From: Andre Renaud <arenaud@designa-electronics.com>
> 

Your Signed-off-by line is missing here, could you resend with this
Signed-off-by line added ?

Also, please change the commit title to:

	mesa3d: add option to enable Freedreno gallium driver

Indeed:

 - We also want the commit log to have the format "<package>:
   <description>"

 - Using a past tense "Added" doesn't make a lot of sense. Your commit
   has not "added" something, it is adding something. So using just
   "add" makes a lot more sense

Could you resend after fixing those minor issues? I had fixed myself
the commit title issue and was about to push your patch, but the
missing Signed-off-by requires you to resend a new version.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com