* [Buildroot] [PATCH] package/llvm: fix typo in llvm.mk
@ 2018-04-12 12:02 Valentin Korenblit
2018-04-12 19:16 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Korenblit @ 2018-04-12 12:02 UTC (permalink / raw)
To: buildroot
"+=" was missing in -DLLVM_TARGETS_TO_BUILD, so LLVM_CONF_OPTS and
HOST_LLVM_CONF_OPTS before this option weren't being considered.
Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
---
package/llvm/llvm.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 4b4f96e5f1..d19f8a0b87 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -42,8 +42,8 @@ LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
# Build backend for target architecture. This include backends like AMDGPU.
LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
-HOST_LLVM_CONF_OPTS = -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
-LLVM_CONF_OPTS = -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
# LLVM target to use for native code generation. This is required for JIT generation.
# It must be set to LLVM_TARGET_ARCH for host and target, otherwise we get
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/llvm: fix typo in llvm.mk
2018-04-12 12:02 [Buildroot] [PATCH] package/llvm: fix typo in llvm.mk Valentin Korenblit
@ 2018-04-12 19:16 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-04-12 19:16 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 12 Apr 2018 14:02:36 +0200, Valentin Korenblit wrote:
> "+=" was missing in -DLLVM_TARGETS_TO_BUILD, so LLVM_CONF_OPTS and
> HOST_LLVM_CONF_OPTS before this option weren't being considered.
>
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> ---
> package/llvm/llvm.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-12 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-12 12:02 [Buildroot] [PATCH] package/llvm: fix typo in llvm.mk Valentin Korenblit
2018-04-12 19:16 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox