Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pixiewps: added missing dependency
Date: Wed, 18 Apr 2018 16:25:10 +0200	[thread overview]
Message-ID: <20180418162510.719ad915@windsurf.numericable.fr> (raw)
In-Reply-To: <1524060503-16067-1-git-send-email-guillaume.bressaix@gmail.com>

Hello Guillaume,

On Wed, 18 Apr 2018 16:08:23 +0200, Guillaume W. Bres wrote:

> +	depends on BR2_TOOLCHAIN_HAS_THREADS=y

Should be just depends on BR2_TOOLCHAIN_HAS_THREADS. You can look at
all the other packages to have examples on how to do things like that.

Also, please add in the commit log something like this:

"""
Fixes:

   http://autobuild.buildroot.org/results/...
"""

with an actual error to a build failure reported by the autobuilders.
The mention "22/46 toolchains have been successfully tested here." is
not useful because we don't know what "here" means, nor which
toolchains have been tested.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-18 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 14:08 [Buildroot] [PATCH 1/1] pixiewps: added missing dependency Guillaume W. Bres
2018-04-18 14:25 ` Thomas Petazzoni [this message]
2018-04-18 15:15 ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2018-04-18 14:33 Guillaume W. Bres
2018-04-18 14:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418162510.719ad915@windsurf.numericable.fr \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox