From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pixiewps: added missing dependency
Date: Wed, 18 Apr 2018 16:50:09 +0200 [thread overview]
Message-ID: <20180418165009.038d822f@windsurf.numericable.fr> (raw)
In-Reply-To: <1524062033-24852-1-git-send-email-guillaume.bressaix@gmail.com>
Hello,
On Wed, 18 Apr 2018 16:33:53 +0200, Guillaume W. Bres wrote:
> Fixes
>
> http://autobuild.buildroot.net/results/0c8d0eeb693ac29739845f489caffc2f9fa3b262/
>
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Thanks, I'll apply. Just a few more comments for future
contributions, as suggestions to improve them:
- Don't use the past tense in the commit log. Your commit has not
"added" something, but it's *adding* something. So please always use
forms like "add missing dependency", "remove this", "change that",
and not a past tense.
- The commit title could be more specific: "add missing dependency on
threads"
- When you send a second iteration of a patch, please generate it with
"git format-patch -v2", which will change the patch prefix to:
[PATCH v2]
And also include a changelog of what changed since the previous
iteration under the "---" that is below the Signed-off-by line. This
helps people reviewing your patches understand what were the changes
between each iteration. For a simple patch like this one, this is
not a big deal of course, but I thought I should mention this best
practice.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-18 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:33 [Buildroot] [PATCH 1/1] pixiewps: added missing dependency Guillaume W. Bres
2018-04-18 14:50 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-18 14:08 Guillaume W. Bres
2018-04-18 14:25 ` Thomas Petazzoni
2018-04-18 15:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418165009.038d822f@windsurf.numericable.fr \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox