From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] lz4: improve static only build support
Date: Thu, 19 Apr 2018 22:50:17 +0200 [thread overview]
Message-ID: <20180419225017.308d2d1e@windsurf.numericable.fr> (raw)
In-Reply-To: <0d4f47355e8ecd124338524f94947fd7cd3e3cb0.1524131196.git.baruch@tkos.co.il>
Hello Baruch,
On Thu, 19 Apr 2018 12:46:36 +0300, Baruch Siach wrote:
> The current method of supporting static only build, removal of all lines
> that match the SHARED regex from lib/Makefile, is crude and fragile.
> Instead, patch lib/Makefile to allow disable of shared libraries.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Thanks for cleaning this up, looks like a good idea. However...
> +LZ4_MAKE_OPTS = DESTDIR=$(STAGING_DIR) PREFIX=/usr
This looks weird. Why is DESTDIR needed at build time ? And how a
DESTDIR=$(STAGING_DIR) in the INSTALL_TARGET_CMDS be the correct thing ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-19 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 9:46 [Buildroot] [PATCH 1/2] lz4: bump to version 1.8.1.2 Baruch Siach
2018-04-19 9:46 ` [Buildroot] [PATCH 2/2] lz4: improve static only build support Baruch Siach
2018-04-19 20:50 ` Thomas Petazzoni [this message]
2018-04-20 4:31 ` Baruch Siach
2018-04-19 20:49 ` [Buildroot] [PATCH 1/2] lz4: bump to version 1.8.1.2 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419225017.308d2d1e@windsurf.numericable.fr \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox