Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] uclibc: fix clock_nanosleep declaration for linuxthreads
@ 2018-05-01 18:06 Waldemar Brodkorb
  2018-05-01 18:14 ` Baruch Siach
  0 siblings, 1 reply; 3+ messages in thread
From: Waldemar Brodkorb @ 2018-05-01 18:06 UTC (permalink / raw)
  To: buildroot

Fixes autobuild errors:
 http://autobuild.buildroot.net/results/a58007263355e2734a8074d52b1b26b88973c39e
 http://autobuild.buildroot.net/results/7d6fd0872efd23c7de552ab637956902b43c3f58

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Reported-by: Baruch Siach <baruch@tkos.co.il>

---
 ...declare-clock_nanosleep-not-only-for-NPTL.patch | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch

diff --git a/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
new file mode 100644
index 0000000..adc6be4
--- /dev/null
+++ b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
@@ -0,0 +1,36 @@
+From ffea49761b3933924cf1125857e9e737eb4a3b25 Mon Sep 17 00:00:00 2001
+From: Waldemar Brodkorb <wbx@openadk.org>
+Date: Tue, 1 May 2018 19:35:20 +0200
+Subject: [PATCH] librt: declare clock_nanosleep not only for NPTL
+
+Reported-by: Baruch Siach <baruch@tkos.co.il>
+Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
+---
+ include/time.h | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/include/time.h b/include/time.h
+index 785c8f6..c29038b 100644
+--- a/include/time.h
++++ b/include/time.h
+@@ -356,7 +356,7 @@ extern int clock_settime (clockid_t __clock_id, const struct timespec *__tp)
+ #  endif /* __UCLIBC_HAS_REALTIME__ */
+ 
+ #  if defined __USE_XOPEN2K && defined __UCLIBC_HAS_ADVANCED_REALTIME__
+-#   ifdef __UCLIBC_HAS_THREADS_NATIVE__
++#   ifdef __UCLIBC_HAS_THREADS__
+ /* High-resolution sleep with the specified clock.
+ 
+    This function is a cancellation point and therefore not marked with
+@@ -367,7 +367,7 @@ extern int clock_nanosleep (clockid_t __clock_id, int __flags,
+ 
+ /* Return clock ID for CPU-time clock.  */
+ extern int clock_getcpuclockid (pid_t __pid, clockid_t *__clock_id) __THROW;
+-#   endif /* __UCLIBC_HAS_THREADS_NATIVE__ */
++#   endif /* __UCLIBC_HAS_THREADS__ */
+ #  endif
+ 
+ #  if defined __UCLIBC_HAS_REALTIME__
+-- 
+2.1.4
+
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] uclibc: fix clock_nanosleep declaration for linuxthreads
  2018-05-01 18:06 [Buildroot] [PATCH] uclibc: fix clock_nanosleep declaration for linuxthreads Waldemar Brodkorb
@ 2018-05-01 18:14 ` Baruch Siach
  2018-05-02  8:25   ` Waldemar Brodkorb
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2018-05-01 18:14 UTC (permalink / raw)
  To: buildroot

Hi Waldemar,

Thanks for your quick response. One question below.

On Tue, May 01, 2018 at 08:06:48PM +0200, Waldemar Brodkorb wrote:
> Fixes autobuild errors:
>  http://autobuild.buildroot.net/results/a58007263355e2734a8074d52b1b26b88973c39e
>  http://autobuild.buildroot.net/results/7d6fd0872efd23c7de552ab637956902b43c3f58
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Reported-by: Baruch Siach <baruch@tkos.co.il>
> 
> ---
>  ...declare-clock_nanosleep-not-only-for-NPTL.patch | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
> 
> diff --git a/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
> new file mode 100644
> index 0000000..adc6be4
> --- /dev/null
> +++ b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
> @@ -0,0 +1,36 @@
> +From ffea49761b3933924cf1125857e9e737eb4a3b25 Mon Sep 17 00:00:00 2001
> +From: Waldemar Brodkorb <wbx@openadk.org>
> +Date: Tue, 1 May 2018 19:35:20 +0200
> +Subject: [PATCH] librt: declare clock_nanosleep not only for NPTL
> +
> +Reported-by: Baruch Siach <baruch@tkos.co.il>
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> +---
> + include/time.h | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/include/time.h b/include/time.h
> +index 785c8f6..c29038b 100644
> +--- a/include/time.h
> ++++ b/include/time.h
> +@@ -356,7 +356,7 @@ extern int clock_settime (clockid_t __clock_id, const struct timespec *__tp)
> + #  endif /* __UCLIBC_HAS_REALTIME__ */
> + 
> + #  if defined __USE_XOPEN2K && defined __UCLIBC_HAS_ADVANCED_REALTIME__
> +-#   ifdef __UCLIBC_HAS_THREADS_NATIVE__
> ++#   ifdef __UCLIBC_HAS_THREADS__

Why does the clock_nanosleep() declaration depend on threading support at all?

> + /* High-resolution sleep with the specified clock.
> + 
> +    This function is a cancellation point and therefore not marked with
> +@@ -367,7 +367,7 @@ extern int clock_nanosleep (clockid_t __clock_id, int __flags,
> + 
> + /* Return clock ID for CPU-time clock.  */
> + extern int clock_getcpuclockid (pid_t __pid, clockid_t *__clock_id) __THROW;
> +-#   endif /* __UCLIBC_HAS_THREADS_NATIVE__ */
> ++#   endif /* __UCLIBC_HAS_THREADS__ */
> + #  endif
> + 
> + #  if defined __UCLIBC_HAS_REALTIME__

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] uclibc: fix clock_nanosleep declaration for linuxthreads
  2018-05-01 18:14 ` Baruch Siach
@ 2018-05-02  8:25   ` Waldemar Brodkorb
  0 siblings, 0 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2018-05-02  8:25 UTC (permalink / raw)
  To: buildroot

Hi,

stupid me, we decoupled both in the mentioned commit,
I'll sent a new patch,

best regards and sorry for iphone tofu..

best regards
 Waldemar 

> Am 01.05.2018 um 20:14 schrieb Baruch Siach <baruch@tkos.co.il>:
> 
> Hi Waldemar,
> 
> Thanks for your quick response. One question below.
> 
>> On Tue, May 01, 2018 at 08:06:48PM +0200, Waldemar Brodkorb wrote:
>> Fixes autobuild errors:
>> http://autobuild.buildroot.net/results/a58007263355e2734a8074d52b1b26b88973c39e
>> http://autobuild.buildroot.net/results/7d6fd0872efd23c7de552ab637956902b43c3f58
>> 
>> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
>> Reported-by: Baruch Siach <baruch@tkos.co.il>
>> 
>> ---
>> ...declare-clock_nanosleep-not-only-for-NPTL.patch | 36 ++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>> create mode 100644 package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
>> 
>> diff --git a/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
>> new file mode 100644
>> index 0000000..adc6be4
>> --- /dev/null
>> +++ b/package/uclibc/0002-librt-declare-clock_nanosleep-not-only-for-NPTL.patch
>> @@ -0,0 +1,36 @@
>> +From ffea49761b3933924cf1125857e9e737eb4a3b25 Mon Sep 17 00:00:00 2001
>> +From: Waldemar Brodkorb <wbx@openadk.org>
>> +Date: Tue, 1 May 2018 19:35:20 +0200
>> +Subject: [PATCH] librt: declare clock_nanosleep not only for NPTL
>> +
>> +Reported-by: Baruch Siach <baruch@tkos.co.il>
>> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
>> +---
>> + include/time.h | 4 ++--
>> + 1 file changed, 2 insertions(+), 2 deletions(-)
>> +
>> +diff --git a/include/time.h b/include/time.h
>> +index 785c8f6..c29038b 100644
>> +--- a/include/time.h
>> ++++ b/include/time.h
>> +@@ -356,7 +356,7 @@ extern int clock_settime (clockid_t __clock_id, const struct timespec *__tp)
>> + #  endif /* __UCLIBC_HAS_REALTIME__ */
>> + 
>> + #  if defined __USE_XOPEN2K && defined __UCLIBC_HAS_ADVANCED_REALTIME__
>> +-#   ifdef __UCLIBC_HAS_THREADS_NATIVE__
>> ++#   ifdef __UCLIBC_HAS_THREADS__
> 
> Why does the clock_nanosleep() declaration depend on threading support at all?
> 
>> + /* High-resolution sleep with the specified clock.
>> + 
>> +    This function is a cancellation point and therefore not marked with
>> +@@ -367,7 +367,7 @@ extern int clock_nanosleep (clockid_t __clock_id, int __flags,
>> + 
>> + /* Return clock ID for CPU-time clock.  */
>> + extern int clock_getcpuclockid (pid_t __pid, clockid_t *__clock_id) __THROW;
>> +-#   endif /* __UCLIBC_HAS_THREADS_NATIVE__ */
>> ++#   endif /* __UCLIBC_HAS_THREADS__ */
>> + #  endif
>> + 
>> + #  if defined __UCLIBC_HAS_REALTIME__
> 
> baruch
> 
> -- 
>     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-02  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-01 18:06 [Buildroot] [PATCH] uclibc: fix clock_nanosleep declaration for linuxthreads Waldemar Brodkorb
2018-05-01 18:14 ` Baruch Siach
2018-05-02  8:25   ` Waldemar Brodkorb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox