From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/download/file: fix file:// protocol handling
Date: Mon, 7 May 2018 13:24:32 +0200 [thread overview]
Message-ID: <20180507132432.32241f44@windsurf> (raw)
In-Reply-To: <1525683042-21087-1-git-send-email-angelo@amarulasolutions.com>
Hello Angelo,
On Mon, 7 May 2018 10:50:42 +0200, Angelo Compagnucci wrote:
> This patch removes the file:// prefix from file url before passing it
> to the cp command. It fixes also a missing / between url directory
> and file part.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
I think it would be good to add a specific example that was failing for
you: an example defconfig, and the relevant part of the build log. This
will help in the future if we wonder why this change was done.
Indeed, your commit log describes *what* is done (which is easily
guessed by looking at the code itself), but not *why* it is done.
I think it is especially important to explain that it is a regression
(and since when).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-05-07 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 8:50 [Buildroot] [PATCH] support/download/file: fix file:// protocol handling Angelo Compagnucci
2018-05-07 11:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507132432.32241f44@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox