[Buildroot] [PATCH] support/download/file: fix file:// protocol handling

[Buildroot] [PATCH] support/download/file: fix file:// protocol handling

[Angelo Compagnucci]

This patch removes the file:// prefix from file url before passing it
to the cp command. It fixes also a missing / between url directory
and file part.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 support/download/file | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/download/file b/support/download/file
index fefd6d2..6dd37b0 100755
--- a/support/download/file
+++ b/support/download/file
@@ -40,4 +40,4 @@ _localfiles() {
     eval ${LOCALFILES} "${@}"
 }
 
-_localfiles ${verbose} "'${dir}${file}'" "'${output}'"
+_localfiles ${verbose} "'${dir##file://}/${file}'" "'${output}'"
-- 
2.7.4

[Buildroot] [PATCH] support/download/file: fix file:// protocol handling

[Thomas Petazzoni]

Hello Angelo,

On Mon,  7 May 2018 10:50:42 +0200, Angelo Compagnucci wrote:
> This patch removes the file:// prefix from file url before passing it
> to the cp command. It fixes also a missing / between url directory
> and file part.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>

I think it would be good to add a specific example that was failing for
you: an example defconfig, and the relevant part of the build log. This
will help in the future if we wonder why this change was done.

Indeed, your commit log describes *what* is done (which is easily
guessed by looking at the code itself), but not *why* it is done.

I think it is especially important to explain that it is a regression
(and since when).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com