From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/8] bluez5_utils: rename options to have the proper suffix
Date: Sun, 13 May 2018 21:18:43 +0200 [thread overview]
Message-ID: <20180513191843.GE22130@scaer> (raw)
In-Reply-To: <20180513190737.26079-2-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-05-13 21:07 +0200, Thomas Petazzoni spake thusly:
> The bluez5_utils Config.in options had a bogus prefix:
> BR2_PACKAGE_BLUEZ5 instead of the expected
> BR2_PACKAGE_BLUEZ5_UTILS. This commit fixes that, and adds the
> appropriate Config.in.legacy handling.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Config.in.legacy | 45 ++++++++++++++++++++++++++++++++++++
> package/bluez5_utils/Config.in | 10 ++++----
> package/bluez5_utils/bluez5_utils.mk | 10 ++++----
> 3 files changed, 55 insertions(+), 10 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 66d3a0c5a8..6d17f7de6d 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -145,6 +145,51 @@ endif
> ###############################################################################
> comment "Legacy options removed in 2018.05"
>
> +config BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH
> + bool "bluez5-utils health plugin option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH has been renamed to
> + BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH.
> +
> +config BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI
> + bool "bluez5-utils midi plugin option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_MIDI
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI has been renamed to
> + BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_MIDI.
> +
> +config BR2_PACKAGE_BLUEZ5_PLUGINS_NFC
> + bool "bluez5-utils nfc plugin option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_NFC
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_BLUEZ5_PLUGINS_NFC has been renamed to
> + BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_NFC.
> +
> +config BR2_PACKAGE_BLUEZ5_PLUGINS_SAP
> + bool "bluez5-utils sap plugin option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SAP
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_BLUEZ5_PLUGINS_SAP has been renamed to
> + BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SAP.
> +
> +config BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS
> + bool "bluez5-utils sixaxis plugin option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SIXAXIS
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS has been renamed to
> + BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SIXAXIS.
> +
> config BR2_PACKAGE_LIBKCAPI_APPS
> bool "libkcapi test applications removed"
> select BR2_LEGACY
> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> index 55831e9b61..c5e8dfbcf7 100644
> --- a/package/bluez5_utils/Config.in
> +++ b/package/bluez5_utils/Config.in
> @@ -56,29 +56,29 @@ config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
> help
> Build BlueZ 5.x experimental Nokia OBEX PC Suite plugin
>
> -config BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH
> +config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH
> bool "build health plugin"
> help
> Build BlueZ 5.x health plugin
>
> -config BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI
> +config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_MIDI
> bool "build midi profile"
> select BR2_PACKAGE_ALSA_LIB
> select BR2_PACKAGE_ALSA_LIB_SEQ
> help
> Build BlueZ 5.x midi plugin
>
> -config BR2_PACKAGE_BLUEZ5_PLUGINS_NFC
> +config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_NFC
> bool "build nfc plugin"
> help
> Build BlueZ 5.x nfc plugin
>
> -config BR2_PACKAGE_BLUEZ5_PLUGINS_SAP
> +config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SAP
> bool "build sap plugin"
> help
> Build BlueZ 5.x sap plugin
>
> -config BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS
> +config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SIXAXIS
> bool "build sixaxis plugin"
> depends on BR2_PACKAGE_HAS_UDEV
> help
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> index 3189855624..aff1fd9796 100644
> --- a/package/bluez5_utils/bluez5_utils.mk
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -41,14 +41,14 @@ BLUEZ5_UTILS_CONF_OPTS += --disable-experimental
> endif
>
> # enable health plugin
> -ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH),y)
> BLUEZ5_UTILS_CONF_OPTS += --enable-health
> else
> BLUEZ5_UTILS_CONF_OPTS += --disable-health
> endif
>
> # enable midi profile
> -ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_MIDI),y)
> BLUEZ5_UTILS_CONF_OPTS += --enable-midi
> BLUEZ5_UTILS_DEPENDENCIES += alsa-lib
> else
> @@ -56,21 +56,21 @@ BLUEZ5_UTILS_CONF_OPTS += --disable-midi
> endif
>
> # enable nfc plugin
> -ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_NFC),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_NFC),y)
> BLUEZ5_UTILS_CONF_OPTS += --enable-nfc
> else
> BLUEZ5_UTILS_CONF_OPTS += --disable-nfc
> endif
>
> # enable sap plugin
> -ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_SAP),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SAP),y)
> BLUEZ5_UTILS_CONF_OPTS += --enable-sap
> else
> BLUEZ5_UTILS_CONF_OPTS += --disable-sap
> endif
>
> # enable sixaxis plugin
> -ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_SIXAXIS),y)
> BLUEZ5_UTILS_CONF_OPTS += --enable-sixaxis
> else
> BLUEZ5_UTILS_CONF_OPTS += --disable-sixaxis
> --
> 2.14.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-05-13 19:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 19:07 [Buildroot] [PATCH 0/8] Fix the Config.in prefix of a number of options Thomas Petazzoni
2018-05-13 19:07 ` [Buildroot] [PATCH 1/8] bluez5_utils: rename options to have the proper suffix Thomas Petazzoni
2018-05-13 19:18 ` Yann E. MORIN [this message]
2018-05-13 19:07 ` [Buildroot] [PATCH 2/8] jquery-ui-themes: rename options to have proper prefix Thomas Petazzoni
2018-05-13 19:19 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 3/8] libftdi: rename option " Thomas Petazzoni
2018-05-13 19:19 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 4/8] ipsec-tools: rename options " Thomas Petazzoni
2018-05-13 19:21 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 5/8] janus-gateway: " Thomas Petazzoni
2018-05-13 19:22 ` Yann E. MORIN
2018-05-14 4:00 ` Ricardo Martincoski
2018-05-13 19:07 ` [Buildroot] [PATCH 6/8] ti-sgx-km: " Thomas Petazzoni
2018-05-13 19:31 ` Yann E. MORIN
2018-05-15 21:52 ` Arnout Vandecappelle
2018-05-16 7:00 ` Thomas Petazzoni
2018-05-16 15:16 ` Arnout Vandecappelle
2018-05-21 21:16 ` Peter Korsgaard
2018-05-22 10:42 ` Arnout Vandecappelle
2018-05-28 20:45 ` Yann E. MORIN
2018-05-29 10:45 ` Arnout Vandecappelle
2018-05-29 17:26 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 7/8] libmediaart: " Thomas Petazzoni
2018-05-13 19:32 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 8/8] utils/check-package: verify the prefix of package Config.in options Thomas Petazzoni
2018-05-14 4:04 ` Ricardo Martincoski
2018-05-21 21:18 ` [Buildroot] [PATCH 0/8] Fix the Config.in prefix of a number of options Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513191843.GE22130@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox