From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] ipsec-tools: rename options to have proper prefix
Date: Sun, 13 May 2018 21:21:26 +0200 [thread overview]
Message-ID: <20180513192126.GH22130@scaer> (raw)
In-Reply-To: <20180513190737.26079-5-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-05-13 21:07 +0200, Thomas Petazzoni spake thusly:
> A number of options in the ipsec-tools package had their Config.in
> option prefixed by BR2_PACKAGE_IPSEC, while the prefix should be
> BR2_PACKAGE_IPSEC_TOOLS. This commit fixes that, and adds the
> necessary Config.in.legacy handling.
>
> Since those options are part of a choice, the legacy handling cannot
> select the new name of the options, so the legacy handling only
> informs the user of the rename.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Config.in.legacy | 24 ++++++++++++++++++++++++
> package/ipsec-tools/Config.in | 8 ++++----
> package/ipsec-tools/ipsec-tools.mk | 6 +++---
> 3 files changed, 31 insertions(+), 7 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 72563031ce..314e0578d8 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -145,6 +145,30 @@ endif
> ###############################################################################
> comment "Legacy options removed in 2018.05"
>
> +config BR2_PACKAGE_IPSEC_SECCTX_DISABLE
> + bool "ipsec-tools security context disable option renamed"
> + select BR2_LEGACY
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_IPSEC_SECCTX_DISABLE was renamed to
> + BR2_PACKAGE_IPSEC_TOOLS_SECCTX_DISABLE.
> +
> +config BR2_PACKAGE_IPSEC_SECCTX_ENABLE
> + bool "ipsec-tools SELinux security context enable option renamed"
> + select BR2_LEGACY
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_IPSEC_SECCTX_ENABLE was renamed to
> + BR2_PACKAGE_IPSEC_TOOLS_SECCTX_ENABLE.
> +
> +config BR2_PACKAGE_IPSEC_SECCTX_KERNEL
> + bool "ipsec-tools kernel security context enable option renamed"
> + select BR2_LEGACY
> + help
> + For consistency reasons, the option
> + BR2_PACKAGE_IPSEC_SECCTX_KERNEL was renamed to
> + BR2_PACKAGE_IPSEC_TOOLS_SECCTX_KERNEL.
> +
> config BR2_PACKAGE_LIBTFDI_CPP
> bool "libftdi C++ bindings option renamed"
> select BR2_LEGACY
> diff --git a/package/ipsec-tools/Config.in b/package/ipsec-tools/Config.in
> index 1635675a36..59154123e6 100644
> --- a/package/ipsec-tools/Config.in
> +++ b/package/ipsec-tools/Config.in
> @@ -57,17 +57,17 @@ config BR2_PACKAGE_IPSEC_TOOLS_HYBRID
>
> choice
> prompt "Security context"
> - default BR2_PACKAGE_IPSEC_SECCTX_DISABLE
> + default BR2_PACKAGE_IPSEC_TOOLS_SECCTX_DISABLE
> help
> Selects whether or not to enable security context support.
>
> -config BR2_PACKAGE_IPSEC_SECCTX_DISABLE
> +config BR2_PACKAGE_IPSEC_TOOLS_SECCTX_DISABLE
> bool "Disable security context support"
>
> -config BR2_PACKAGE_IPSEC_SECCTX_ENABLE
> +config BR2_PACKAGE_IPSEC_TOOLS_SECCTX_ENABLE
> bool "Enable SELinux security context support"
>
> -config BR2_PACKAGE_IPSEC_SECCTX_KERNEL
> +config BR2_PACKAGE_IPSEC_TOOLS_SECCTX_KERNEL
> bool "Enable kernel security context"
>
> endchoice
> diff --git a/package/ipsec-tools/ipsec-tools.mk b/package/ipsec-tools/ipsec-tools.mk
> index c0b180de55..ddae9a75f3 100644
> --- a/package/ipsec-tools/ipsec-tools.mk
> +++ b/package/ipsec-tools/ipsec-tools.mk
> @@ -68,13 +68,13 @@ else
> IPSEC_TOOLS_CONF_OPTS += --disable-hybrid
> endif
>
> -ifeq ($(BR2_PACKAGE_IPSEC_SECCTX_DISABLE),y)
> +ifeq ($(BR2_PACKAGE_IPSEC_TOOLS_SECCTX_DISABLE),y)
> IPSEC_TOOLS_CONF_OPTS += --enable-security-context=no
> endif
> -ifeq ($(BR2_PACKAGE_IPSEC_SECCTX_ENABLE),y)
> +ifeq ($(BR2_PACKAGE_IPSEC_TOOLS_SECCTX_ENABLE),y)
> IPSEC_TOOLS_CONF_OPTS += --enable-security-context=yes
> endif
> -ifeq ($(BR2_PACKAGE_IPSEC_SECCTX_KERNEL),y)
> +ifeq ($(BR2_PACKAGE_IPSEC_TOOLS_SECCTX_KERNEL),y)
> IPSEC_TOOLS_CONF_OPTS += --enable-security-context=kernel
> endif
>
> --
> 2.14.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-05-13 19:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 19:07 [Buildroot] [PATCH 0/8] Fix the Config.in prefix of a number of options Thomas Petazzoni
2018-05-13 19:07 ` [Buildroot] [PATCH 1/8] bluez5_utils: rename options to have the proper suffix Thomas Petazzoni
2018-05-13 19:18 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 2/8] jquery-ui-themes: rename options to have proper prefix Thomas Petazzoni
2018-05-13 19:19 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 3/8] libftdi: rename option " Thomas Petazzoni
2018-05-13 19:19 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 4/8] ipsec-tools: rename options " Thomas Petazzoni
2018-05-13 19:21 ` Yann E. MORIN [this message]
2018-05-13 19:07 ` [Buildroot] [PATCH 5/8] janus-gateway: " Thomas Petazzoni
2018-05-13 19:22 ` Yann E. MORIN
2018-05-14 4:00 ` Ricardo Martincoski
2018-05-13 19:07 ` [Buildroot] [PATCH 6/8] ti-sgx-km: " Thomas Petazzoni
2018-05-13 19:31 ` Yann E. MORIN
2018-05-15 21:52 ` Arnout Vandecappelle
2018-05-16 7:00 ` Thomas Petazzoni
2018-05-16 15:16 ` Arnout Vandecappelle
2018-05-21 21:16 ` Peter Korsgaard
2018-05-22 10:42 ` Arnout Vandecappelle
2018-05-28 20:45 ` Yann E. MORIN
2018-05-29 10:45 ` Arnout Vandecappelle
2018-05-29 17:26 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 7/8] libmediaart: " Thomas Petazzoni
2018-05-13 19:32 ` Yann E. MORIN
2018-05-13 19:07 ` [Buildroot] [PATCH 8/8] utils/check-package: verify the prefix of package Config.in options Thomas Petazzoni
2018-05-14 4:04 ` Ricardo Martincoski
2018-05-21 21:18 ` [Buildroot] [PATCH 0/8] Fix the Config.in prefix of a number of options Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513192126.GH22130@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox