[Buildroot] [PATCH 1/2] modem-manager: fix test of unset variable in init script

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Mon, 16 Apr 2018 17:53:25 +0200, Arnout Vandecappelle wrote:

> > So I will prepare a series removing the tests from the startup scripts.  
> 
>  Well, part of the position we already stated a few times in the past is that we
> should make our sysvinit scripts conform to a pattern. So I think the optimal
> approach is:
> 
> 1. Update the sysvinit scripts of one or two packages to conform to this
> pattern. Note that we have not really discussed the actual pattern, just a few
> preferences (e.g. don't test for the existence of the daemon). So it is
> important to update only one or two scripts so we can get convergence on the
> desired pattern, before updating many more packages.
> 
> 2. Document this pattern in the manual. For me, it would be sufficient to refer
> to an existing sysvinit script rather than repeating it in the manual.
> 
> 3. Update more packages.
> 
> 4. Add some support to check-package to identify common mistakes in the pattern.

Agreed on this plan.

Anybody interested in this effort ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com