[Buildroot] [PATCH 1/2] modem-manager: fix test of unset variable in init script

[Carlos Santos <casantos@datacom.ind.br>]

> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "Arnout Vandecappelle" <arnout@mind.be>
> Cc: "Carlos Santos" <casantos@datacom.ind.br>, "Yann Morin" <yann.morin.1998@free.fr>, "buildroot"
> <buildroot@buildroot.org>, "Aleksander Morgado" <aleksander@aleksander.es>, "Peter Korsgaard" <peter@korsgaard.com>
> Sent: Monday, May 14, 2018 3:57:06 AM
> Subject: Re: [Buildroot] [PATCH 1/2] modem-manager: fix test of unset variable in init script

> Hello,
> 
> On Mon, 16 Apr 2018 17:53:25 +0200, Arnout Vandecappelle wrote:
> 
>> > So I will prepare a series removing the tests from the startup scripts.
>> 
>>  Well, part of the position we already stated a few times in the past is that we
>> should make our sysvinit scripts conform to a pattern. So I think the optimal
>> approach is:
>> 
>> 1. Update the sysvinit scripts of one or two packages to conform to this
>> pattern. Note that we have not really discussed the actual pattern, just a few
>> preferences (e.g. don't test for the existence of the daemon). So it is
>> important to update only one or two scripts so we can get convergence on the
>> desired pattern, before updating many more packages.
>> 
>> 2. Document this pattern in the manual. For me, it would be sufficient to refer
>> to an existing sysvinit script rather than repeating it in the manual.
>> 
>> 3. Update more packages.
>> 
>> 4. Add some support to check-package to identify common mistakes in the pattern.
> 
> Agreed on this plan.
> 
> Anybody interested in this effort ?

I already have some scratches and will send some patches as soon as
possible. <o/

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer