[Buildroot] [PATCH] toolchain: GCC bug 85862

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Matt Weber]

GCC < 7.x hangs while building libnss for the Microblaze Arch.

Discovered by
http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df

Reported:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862

Simlar to:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 package/ecryptfs-utils/Config.in | 4 ++++
 package/libnss/Config.in         | 4 ++++
 toolchain/Config.in              | 8 ++++++++
 3 files changed, 16 insertions(+)

diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in
index bb4cc64..9d4a905 100644
--- a/package/ecryptfs-utils/Config.in
+++ b/package/ecryptfs-utils/Config.in
@@ -7,6 +7,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr
 	depends on !BR2_MIPS_NABI32 # libnss
 	depends on !BR2_STATIC_LIBS # libnss, keyutils
+	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # microblaze specific & GCC < 7.x
 	select BR2_PACKAGE_KEYUTILS
 	select BR2_PACKAGE_LIBNSS
 	# runtime dependency only, some scripts are using the
@@ -35,3 +36,6 @@ comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynami library"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
 		BR2_STATIC_LIBS
+
+comment "ecryptfs selects libnss and libnss needs a toolchain not affected by GCC bug 85862"
+	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862
diff --git a/package/libnss/Config.in b/package/libnss/Config.in
index 599c9a6..34ddb91 100644
--- a/package/libnss/Config.in
+++ b/package/libnss/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBNSS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
 	depends on !BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862
 	select BR2_PACKAGE_LIBNSPR
 	select BR2_PACKAGE_SQLITE
 	select BR2_PACKAGE_ZLIB
@@ -18,3 +19,6 @@ config BR2_PACKAGE_LIBNSS
 comment "libnss needs a toolchain w/ threads, dynamic library"
 	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
+comment "libnss needs a toolchain not affected by GCC bug 85862"
+	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 121ddb4..2479a65 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -84,6 +84,14 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 	default y if BR2_m68k_cf5208
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
 
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
+# An infinite loop exists in the find_base_term() logic of 6.x
+# on microblaze.  http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df/
+config BR2_TOOLCHAIN_HAS_GCC_BUG_85862
+	bool
+	default y if BR2_microblaze
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
+
 config BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	bool
 
-- 
1.9.1

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Peter Korsgaard]

>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > GCC < 7.x hangs while building libnss for the Microblaze Arch.
 > Discovered by
 > http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df

 > Reported:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862

 > Simlar to:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
 > ---
 >  package/ecryptfs-utils/Config.in | 4 ++++
 >  package/libnss/Config.in         | 4 ++++
 >  toolchain/Config.in              | 8 ++++++++

You forgot qt5webengine. I know that qt5webengine currently isn't
available for Microblaze / issue only happens on Microblaze, but I have
added it anyway for consistency.

>  3 files changed, 16 insertions(+)

 > diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in
 > index bb4cc64..9d4a905 100644
 > --- a/package/ecryptfs-utils/Config.in
 > +++ b/package/ecryptfs-utils/Config.in
 > @@ -7,6 +7,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
 >  	depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr
 >  	depends on !BR2_MIPS_NABI32 # libnss
 >  	depends on !BR2_STATIC_LIBS # libnss, keyutils
 > +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # microblaze specific & GCC < 7.x
 >  	select BR2_PACKAGE_KEYUTILS
 >  	select BR2_PACKAGE_LIBNSS
 >  	# runtime dependency only, some scripts are using the
 > @@ -35,3 +36,6 @@ comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynami library"
 >  	depends on BR2_USE_MMU
 >  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
 >  		BR2_STATIC_LIBS
 > +
 > +comment "ecryptfs selects libnss and libnss needs a toolchain not affected by GCC bug 85862"
 > +	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862

We normally just say 'ecryptfs needs a toolchain not affected by..', so
I've changed it to that and committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Thomas Petazzoni]

Hello,

On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
> GCC < 7.x hangs while building libnss for the Microblaze Arch.
> 
> Discovered by
> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
> 
> Reported:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
> 
> Simlar to:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
> 
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Beyond the libnss issue, we do have at least three other Microblaze timeouts. However, I think Romain Naour had identified a different issue for those:

http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel

Affected packages: flare-engine, boost, gst-ffmpeg.

Romain, Matt, would it be possible to make progress with those timeouts
as well ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Romain Naour]

Hi Thomas,

Le 22/05/2018 ? 23:00, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
>> GCC < 7.x hangs while building libnss for the Microblaze Arch.
>>
>> Discovered by
>> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
>>
>> Reported:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862

This bug has been marked as a duclicate of the bug I identified.

>>
>> Simlar to:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
>>
>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> 
> Beyond the libnss issue, we do have at least three other Microblaze timeouts. However, I think Romain Naour had identified a different issue for those:
> 
> http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel
> 
> Affected packages: flare-engine, boost, gst-ffmpeg.

We can mark these packages affected by bug 85852 or 85180.

> 
> Romain, Matt, would it be possible to make progress with those timeouts
> as well ?

For now, it's not clear why we have theses timeout with the last microblaze
toolchain bump. Uptream don't recommend to backport this patch "too risky".

Best regards,
Romain

> 
> Thanks a lot!
> 
> Thomas
> 

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Matthew Weber]

Romain,

On Wed, May 23, 2018 at 3:38 PM, Romain Naour <romain.naour@gmail.com> wrote:
>
> Hi Thomas,
>
> Le 22/05/2018 ? 23:00, Thomas Petazzoni a ?crit :
> > Hello,
> >
> > On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
> >> GCC < 7.x hangs while building libnss for the Microblaze Arch.
> >>
> >> Discovered by
> >> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
> >>
> >> Reported:
> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
>
> This bug has been marked as a duclicate of the bug I identified.
>
> >>
> >> Simlar to:
> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
> >>
> >> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> >
> > Beyond the libnss issue, we do have at least three other Microblaze timeouts. However, I think Romain Naour had identified a different issue for those:
> >
> > http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel
> >
> > Affected packages: flare-engine, boost, gst-ffmpeg.
>
> We can mark these packages affected by bug 85852 or 85180.
>

Any proposed ways to impl other then adding another BR2_TOOLCHAIN_HAS_GCC_BUG_*

Matt

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Romain Naour]

Hi Matt,

Le 23/05/2018 ? 22:57, Matthew Weber a ?crit?:
> Romain,
> 
> On Wed, May 23, 2018 at 3:38 PM, Romain Naour <romain.naour@gmail.com> wrote:
>>
>> Hi Thomas,
>>
>> Le 22/05/2018 ? 23:00, Thomas Petazzoni a ?crit :
>>> Hello,
>>>
>>> On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
>>>> GCC < 7.x hangs while building libnss for the Microblaze Arch.
>>>>
>>>> Discovered by
>>>> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
>>>>
>>>> Reported:
>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
>>
>> This bug has been marked as a duclicate of the bug I identified.
>>
>>>>
>>>> Simlar to:
>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
>>>>
>>>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>>>
>>> Beyond the libnss issue, we do have at least three other Microblaze timeouts. However, I think Romain Naour had identified a different issue for those:
>>>
>>> http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel
>>>
>>> Affected packages: flare-engine, boost, gst-ffmpeg.
>>
>> We can mark these packages affected by bug 85852 or 85180.
>>
> 
> Any proposed ways to impl other then adding another BR2_TOOLCHAIN_HAS_GCC_BUG_*

We can add an autobuilder exception to reject configs building these packages
with a microblaze toolchain.

Best regards,
Romain

> 
> Matt
> 

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Matthew Weber]

All,

On Wed, May 23, 2018 at 4:08 PM, Romain Naour <romain.naour@gmail.com> wrote:
> Hi Matt,
>
> Le 23/05/2018 ? 22:57, Matthew Weber a ?crit :
>> Romain,
>>
>> On Wed, May 23, 2018 at 3:38 PM, Romain Naour <romain.naour@gmail.com> wrote:
>>>
>>> Hi Thomas,
>>>
>>> Le 22/05/2018 ? 23:00, Thomas Petazzoni a ?crit :
>>>> Hello,
>>>>
>>>> On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
>>>>> GCC < 7.x hangs while building libnss for the Microblaze Arch.
>>>>>
>>>>> Discovered by
>>>>> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
>>>>>
>>>>> Reported:
>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
>>>
>>> This bug has been marked as a duclicate of the bug I identified.
>>>
>>>>>
>>>>> Simlar to:
>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
>>>>>
>>>>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>>>>
>>>> Beyond the libnss issue, we do have at least three other Microblaze timeouts. However, I think Romain Naour had identified a different issue for those:
>>>>
>>>> http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel
>>>>
>>>> Affected packages: flare-engine, boost, gst-ffmpeg.
>>>
>>> We can mark these packages affected by bug 85852 or 85180.
>>>
>>
>> Any proposed ways to impl other then adding another BR2_TOOLCHAIN_HAS_GCC_BUG_*
>
> We can add an autobuilder exception to reject configs building these packages
> with a microblaze toolchain.

True as we don't have GCC8 support so we can't use the kconfig method
for filtering this one out.
http://patchwork.ozlabs.org/patch/919409/

Matt

[Buildroot] [PATCH] toolchain: GCC bug 85862

[davidb]

Hi!

Regarding the commit id bd03966d4ebeb284ac3afb5f3b8cba13da2b9983 that 
disables qt5webengine when the bug 85862 can be triggered on microblaze 
arch, I can't enable qt5webengine when selecting QT5 Latest version 
(5.10) and x86_64 arch.

I think the test about the bug should be inverted:

diff --git a/package/qt5/qt5webengine/Config.in 
b/package/qt5/qt5webengine/Config.in
index 38486c6dcf..744d659567 100644
--- a/package/qt5/qt5webengine/Config.in
+++ b/package/qt5/qt5webengine/Config.in
@@ -31,7 +31,7 @@ config BR2_PACKAGE_QT5WEBENGINE
         depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo
         depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu
         depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu
-       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || 
BR2_PACKAGE_QT5_VERSION_5_6 # libnss
+       depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || 
BR2_PACKAGE_QT5_VERSION_5_6 # libnss
         depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, 
qt5base-dbus
         depends on BR2_USE_WCHAR # libglib2
         depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, 
qt5base-eglfs

David.

Le 23/05/2018 23:55, Matthew Weber a ?crit?:
> All,
> 
> On Wed, May 23, 2018 at 4:08 PM, Romain Naour <romain.naour@gmail.com> 
> wrote:
>> Hi Matt,
>> 
>> Le 23/05/2018 ? 22:57, Matthew Weber a ?crit :
>>> Romain,
>>> 
>>> On Wed, May 23, 2018 at 3:38 PM, Romain Naour 
>>> <romain.naour@gmail.com> wrote:
>>>> 
>>>> Hi Thomas,
>>>> 
>>>> Le 22/05/2018 ? 23:00, Thomas Petazzoni a ?crit :
>>>>> Hello,
>>>>> 
>>>>> On Mon, 21 May 2018 15:29:42 -0500, Matt Weber wrote:
>>>>>> GCC < 7.x hangs while building libnss for the Microblaze Arch.
>>>>>> 
>>>>>> Discovered by
>>>>>> http://autobuild.buildroot.net/results/158e8ebb39713e1b436a5cc1a1916f46c30694df
>>>>>> 
>>>>>> Reported:
>>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
>>>> 
>>>> This bug has been marked as a duclicate of the bug I identified.
>>>> 
>>>>>> 
>>>>>> Simlar to:
>>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49218
>>>>>> 
>>>>>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>>>>> 
>>>>> Beyond the libnss issue, we do have at least three other Microblaze 
>>>>> timeouts. However, I think Romain Naour had identified a different 
>>>>> issue for those:
>>>>> 
>>>>> http://autobuild.buildroot.net/?status=TIMEOUT&arch=microblazeel
>>>>> 
>>>>> Affected packages: flare-engine, boost, gst-ffmpeg.
>>>> 
>>>> We can mark these packages affected by bug 85852 or 85180.
>>>> 
>>> 
>>> Any proposed ways to impl other then adding another 
>>> BR2_TOOLCHAIN_HAS_GCC_BUG_*
>> 
>> We can add an autobuilder exception to reject configs building these 
>> packages
>> with a microblaze toolchain.
> 
> True as we don't have GCC8 support so we can't use the kconfig method
> for filtering this one out.
> http://patchwork.ozlabs.org/patch/919409/
> 
> Matt
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH] toolchain: GCC bug 85862

[Thomas Petazzoni]

Hello,

On Thu, 07 Jun 2018 14:43:46 +0200, davidb wrote:

> Regarding the commit id bd03966d4ebeb284ac3afb5f3b8cba13da2b9983 that 
> disables qt5webengine when the bug 85862 can be triggered on microblaze 
> arch, I can't enable qt5webengine when selecting QT5 Latest version 
> (5.10) and x86_64 arch.
> 
> I think the test about the bug should be inverted:
> 
> diff --git a/package/qt5/qt5webengine/Config.in 
> b/package/qt5/qt5webengine/Config.in
> index 38486c6dcf..744d659567 100644
> --- a/package/qt5/qt5webengine/Config.in
> +++ b/package/qt5/qt5webengine/Config.in
> @@ -31,7 +31,7 @@ config BR2_PACKAGE_QT5WEBENGINE
>          depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo
>          depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu
>          depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu
> -       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || 
> BR2_PACKAGE_QT5_VERSION_5_6 # libnss
> +       depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || 
> BR2_PACKAGE_QT5_VERSION_5_6 # libnss

Gah, indeed! Could you send a patch to fix this ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com