From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/7] support/dockerfile: install flake8
Date: Sun, 27 May 2018 18:42:13 +0200 [thread overview]
Message-ID: <20180527164213.GD2965@scaer> (raw)
In-Reply-To: <1520910585-19097-6-git-send-email-ricardo.martincoski@gmail.com>
Ricardo, All,
On 2018-03-13 00:09 -0300, Ricardo Martincoski spake thusly:
> Use the latest version of the tool because it is actively maintained.
> But use a fixed version of the tool and its dependencies to get stable
> results. It can be manually bumped from time to time.
[--SNIP--]
> +# For check-flake8
> +RUN python -m pip install --upgrade pip setuptools wheel && \
So, back when you submnitted this patch, I ACKed it. But I missed that
this command really means we can't reproduce the docker file, because it
will use versions of pip, setuptools, and wheel that are current at the
time the command is run.
I.e. today I could very well get something that is different from the
version we got back at 20180205.0730 when we last built the docker
image.
This is not really nice... :-(
Do you think we could get away without running this command at all, and
just run the pip-install one, below, since we force the version of the
modules we isntall?
Regards,
Yann E. MORIN.
> + pip install -q \
> + flake8==3.5.0 \
> + mccabe==0.6.1 \
> + pycodestyle==2.3.1 \
> + pyflakes==1.6.0
> +
> # To be able to generate a toolchain with locales, enable one UTF-8 locale
> RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen && \
> /usr/sbin/locale-gen
> --
> 2.7.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-05-27 16:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 3:09 [Buildroot] [PATCH v3 0/7] fix Python code style v3 Ricardo Martincoski
2018-03-13 3:09 ` [Buildroot] [PATCH v3 1/7] genrandconfig: fix code style Ricardo Martincoski
2018-03-13 21:27 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 2/7] size-stats-compare: " Ricardo Martincoski
2018-03-13 21:27 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 3/7] test_python_cryptography: " Ricardo Martincoski
2018-03-13 7:39 ` Yegor Yefremov
2018-03-13 21:32 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 4/7] scanpypi: " Ricardo Martincoski
2018-03-13 7:39 ` Yegor Yefremov
2018-03-13 21:32 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 5/7] support/dockerfile: install flake8 Ricardo Martincoski
2018-03-13 17:22 ` Yann E. MORIN
2018-03-13 21:37 ` Peter Korsgaard
2018-05-27 16:42 ` Yann E. MORIN [this message]
2018-05-28 3:00 ` Ricardo Martincoski
2018-05-28 19:44 ` Yann E. MORIN
2018-05-29 3:43 ` Ricardo Martincoski
2018-05-30 15:36 ` Yann E. MORIN
2018-03-13 3:09 ` [Buildroot] [PATCH v3 6/7] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-03-13 18:15 ` Yann E. MORIN
2018-03-14 23:16 ` Ricardo Martincoski
2018-03-18 16:25 ` Yann E. MORIN
2018-03-30 21:12 ` Yann E. MORIN
2018-03-30 22:38 ` Ricardo Martincoski
2018-03-31 20:49 ` Thomas Petazzoni
2018-03-13 3:09 ` [Buildroot] [PATCH v3 7/7] .flake8: ignore utils/diffconfig Ricardo Martincoski
2018-03-13 21:38 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180527164213.GD2965@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox