From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 7/7] .flake8: ignore utils/diffconfig
Date: Tue, 13 Mar 2018 22:38:07 +0100 [thread overview]
Message-ID: <87sh93irls.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1520910585-19097-8-git-send-email-ricardo.martincoski@gmail.com> (Ricardo Martincoski's message of "Tue, 13 Mar 2018 00:09:45 -0300")
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:
> This script comes from the kernel source, so ignore any code style
> warnings for it in order to keep it as close as possible to the original
> one, making synchronization between repos easier.
> The option --exclude for flake8/pycodestyle is an absolute list and has
> a default, so ideally the default values should be added too.
> But the use cases for flake8 in the tree are:
> - when developing a new script or changing an existing one, the
> developer calls flake8 only on that script;
> - in the GitLab job, a list of all Python files to be tested is created
> and then passed to flake8.
> None of these involve calling 'flake8' without parameters, so don't care
> about adding the default value.
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Changes v2 -> v3:
> - no changes
> Changes v1 -> v2:
> - instead of tweaking even more the script from the kernel source,
> ignore any warnings for it; (suggested by Thomas Petazzoni)
> - move the patch after the one adding the GitLab job so I can
> reference it in the commit message.
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-03-13 21:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 3:09 [Buildroot] [PATCH v3 0/7] fix Python code style v3 Ricardo Martincoski
2018-03-13 3:09 ` [Buildroot] [PATCH v3 1/7] genrandconfig: fix code style Ricardo Martincoski
2018-03-13 21:27 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 2/7] size-stats-compare: " Ricardo Martincoski
2018-03-13 21:27 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 3/7] test_python_cryptography: " Ricardo Martincoski
2018-03-13 7:39 ` Yegor Yefremov
2018-03-13 21:32 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 4/7] scanpypi: " Ricardo Martincoski
2018-03-13 7:39 ` Yegor Yefremov
2018-03-13 21:32 ` Peter Korsgaard
2018-03-13 3:09 ` [Buildroot] [PATCH v3 5/7] support/dockerfile: install flake8 Ricardo Martincoski
2018-03-13 17:22 ` Yann E. MORIN
2018-03-13 21:37 ` Peter Korsgaard
2018-05-27 16:42 ` Yann E. MORIN
2018-05-28 3:00 ` Ricardo Martincoski
2018-05-28 19:44 ` Yann E. MORIN
2018-05-29 3:43 ` Ricardo Martincoski
2018-05-30 15:36 ` Yann E. MORIN
2018-03-13 3:09 ` [Buildroot] [PATCH v3 6/7] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-03-13 18:15 ` Yann E. MORIN
2018-03-14 23:16 ` Ricardo Martincoski
2018-03-18 16:25 ` Yann E. MORIN
2018-03-30 21:12 ` Yann E. MORIN
2018-03-30 22:38 ` Ricardo Martincoski
2018-03-31 20:49 ` Thomas Petazzoni
2018-03-13 3:09 ` [Buildroot] [PATCH v3 7/7] .flake8: ignore utils/diffconfig Ricardo Martincoski
2018-03-13 21:38 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh93irls.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox