Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl
@ 2018-06-04 17:03 Fabrice Fontaine
  2018-06-04 19:49 ` Thomas Petazzoni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-06-04 17:03 UTC (permalink / raw)
  To: buildroot

Since version 1.8.0, php-amqp needs a rabbitmq-c with openssl support:
https://github.com/pdezwart/php-amqp/issues/310

SSL support is disabled in rabbitmq-c if BR2_STATIC_LIBS is set however
don't add an unneeded !BR2_STATIC_LIBS dependency in Config.in as all
PHP External Extensions depends on !BR2_STATIC_LIBS
(see package/Config.in)

Fixes:
 - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Baruch Siach and Thomas Petazzoni):
 - Remove unneeded !BR2_STATIC_LIBS in Config.in as all PHP External
   Extensions depends on !BR2_STATIC_LIBS (see package/Config.in)

 package/php-amqp/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
index 0aa2021f5a..dc779f0ee0 100644
--- a/package/php-amqp/Config.in
+++ b/package/php-amqp/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PHP_AMQP
 	bool "php-amqp"
 	depends on BR2_PACKAGE_PHP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
+	select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
 	select BR2_PACKAGE_RABBITMQ_C
 	help
 	  Communicate with any AMQP compliant server.
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl
  2018-06-04 17:03 [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl Fabrice Fontaine
@ 2018-06-04 19:49 ` Thomas Petazzoni
  2018-06-17 15:49 ` Peter Korsgaard
  2018-07-17  7:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-06-04 19:49 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  4 Jun 2018 19:03:29 +0200, Fabrice Fontaine wrote:
> Since version 1.8.0, php-amqp needs a rabbitmq-c with openssl support:
> https://github.com/pdezwart/php-amqp/issues/310
> 
> SSL support is disabled in rabbitmq-c if BR2_STATIC_LIBS is set however
> don't add an unneeded !BR2_STATIC_LIBS dependency in Config.in as all
> PHP External Extensions depends on !BR2_STATIC_LIBS
> (see package/Config.in)
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Baruch Siach and Thomas Petazzoni):
>  - Remove unneeded !BR2_STATIC_LIBS in Config.in as all PHP External
>    Extensions depends on !BR2_STATIC_LIBS (see package/Config.in)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl
  2018-06-04 17:03 [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl Fabrice Fontaine
  2018-06-04 19:49 ` Thomas Petazzoni
@ 2018-06-17 15:49 ` Peter Korsgaard
  2018-07-17  7:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-06-17 15:49 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Since version 1.8.0, php-amqp needs a rabbitmq-c with openssl support:
 > https://github.com/pdezwart/php-amqp/issues/310

 > SSL support is disabled in rabbitmq-c if BR2_STATIC_LIBS is set however
 > don't add an unneeded !BR2_STATIC_LIBS dependency in Config.in as all
 > PHP External Extensions depends on !BR2_STATIC_LIBS
 > (see package/Config.in)

 > Fixes:
 >  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2 (after review of Baruch Siach and Thomas Petazzoni):
 >  - Remove unneeded !BR2_STATIC_LIBS in Config.in as all PHP External
 >    Extensions depends on !BR2_STATIC_LIBS (see package/Config.in)

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl
  2018-06-04 17:03 [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl Fabrice Fontaine
  2018-06-04 19:49 ` Thomas Petazzoni
  2018-06-17 15:49 ` Peter Korsgaard
@ 2018-07-17  7:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-07-17  7:29 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Since version 1.8.0, php-amqp needs a rabbitmq-c with openssl support:
 > https://github.com/pdezwart/php-amqp/issues/310

 > SSL support is disabled in rabbitmq-c if BR2_STATIC_LIBS is set however
 > don't add an unneeded !BR2_STATIC_LIBS dependency in Config.in as all
 > PHP External Extensions depends on !BR2_STATIC_LIBS
 > (see package/Config.in)

 > Fixes:
 >  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2 (after review of Baruch Siach and Thomas Petazzoni):
 >  - Remove unneeded !BR2_STATIC_LIBS in Config.in as all PHP External
 >    Extensions depends on !BR2_STATIC_LIBS (see package/Config.in)

Committed to 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-17  7:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-04 17:03 [Buildroot] [PATCH v2,1/1] php-amqp: selects openssl Fabrice Fontaine
2018-06-04 19:49 ` Thomas Petazzoni
2018-06-17 15:49 ` Peter Korsgaard
2018-07-17  7:29 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox