[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Carlos Santos]

We are working to make all sysvinit scripts conformant to a pattern and
/etc/default/ seems to be a good choice, since 34 packages already get
optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/.  This will
be fixed in a future patch that will refactor the init scripts.

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
 package/netplug/S29netplug | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/netplug/S29netplug b/package/netplug/S29netplug
index 03422499d6..04cac9f07c 100755
--- a/package/netplug/S29netplug
+++ b/package/netplug/S29netplug
@@ -22,8 +22,8 @@ elif [ -f /etc/rc.d/init.d/functions ]; then
 fi
 
 # Source networking configuration.
-if [ -f /etc/sysconfig/network ]; then
-	. /etc/sysconfig/network
+if [ -f /etc/default/network ]; then
+	. /etc/default/network
 
 	# Check that networking is up.
 	[ ${NETWORKING} = "no" ] && exit 0
@@ -32,8 +32,8 @@ elif [ ! -f /etc/network/interfaces ]; then
 	exit 0
 fi
 
-if [ -f /etc/sysconfig/netplugd ]; then
-    . /etc/sysconfig/netplugd
+if [ -f /etc/default/netplugd ]; then
+    . /etc/default/netplugd
 fi
 
 # See how we were called.
-- 
2.17.0

[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Carlos Santos]

We are working to make all sysvinit scripts conformant to a pattern and
/etc/default/ seems to be a good choice, since 34 packages already get
optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/.  This will
be fixed in a future patch that will refactor the init scripts.

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
 package/netplug/S29netplug | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/netplug/S29netplug b/package/netplug/S29netplug
index 03422499d6..04cac9f07c 100755
--- a/package/netplug/S29netplug
+++ b/package/netplug/S29netplug
@@ -22,8 +22,8 @@ elif [ -f /etc/rc.d/init.d/functions ]; then
 fi
 
 # Source networking configuration.
-if [ -f /etc/sysconfig/network ]; then
-	. /etc/sysconfig/network
+if [ -f /etc/default/network ]; then
+	. /etc/default/network
 
 	# Check that networking is up.
 	[ ${NETWORKING} = "no" ] && exit 0
@@ -32,8 +32,8 @@ elif [ ! -f /etc/network/interfaces ]; then
 	exit 0
 fi
 
-if [ -f /etc/sysconfig/netplugd ]; then
-    . /etc/sysconfig/netplugd
+if [ -f /etc/default/netplugd ]; then
+    . /etc/default/netplugd
 fi
 
 # See how we were called.
-- 
2.17.0

[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Thomas Petazzoni]

Hello,

On Mon,  4 Jun 2018 23:24:59 -0300, Carlos Santos wrote:
> We are working to make all sysvinit scripts conformant to a pattern and
> /etc/default/ seems to be a good choice, since 34 packages already get
> optional configurations from files at that directory.
> 
> netplug still installs an init script at /etc/rc.d/init.d/.  This will
> be fixed in a future patch that will refactor the init scripts.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
>  package/netplug/S29netplug | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Thomas Petazzoni]

Hello,

On Mon,  4 Jun 2018 23:24:59 -0300, Carlos Santos wrote:
> We are working to make all sysvinit scripts conformant to a pattern and
> /etc/default/ seems to be a good choice, since 34 packages already get
> optional configurations from files at that directory.
> 
> netplug still installs an init script at /etc/rc.d/init.d/.  This will
> be fixed in a future patch that will refactor the init scripts.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>

Since you're looking at netplug, perhaps you could look at
https://bugs.busybox.net/show_bug.cgi?id=10661 ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] netplug: look for init script configurations at /etc/default/

[Peter Korsgaard]

>>>>> "Carlos" == Carlos Santos <casantos@datacom.com.br> writes:

 > We are working to make all sysvinit scripts conformant to a pattern and
 > /etc/default/ seems to be a good choice, since 34 packages already get
 > optional configurations from files at that directory.

 > netplug still installs an init script at /etc/rc.d/init.d/.  This will
 > be fixed in a future patch that will refactor the init scripts.

 > Signed-off-by: Carlos Santos <casantos@datacom.com.br>

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard