[Buildroot] [PATCH 1/1] More complete usage string.

[Buildroot] [PATCH 1/1] More complete usage string.

[Florian La Roche]

More complete usage string for the logging service.


Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
---
 package/busybox/S01logging | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/busybox/S01logging b/package/busybox/S01logging
index 4632a4cc99..fcb3e7d236 100644
--- a/package/busybox/S01logging
+++ b/package/busybox/S01logging
@@ -33,7 +33,7 @@ case "$1" in
 	start
 	;;
   *)
-	echo "Usage: $0 {start|stop|restart}"
+	echo "Usage: $0 {start|stop|restart|reload}"
 	exit 1
 esac
 
-- 
2.17.0

Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz
Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart
Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart
Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849
This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form.
Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.
We do care about the environment! - Please consider the environment before printing this e-mail.

[Buildroot] [PATCH 1/1] More complete usage string.

[Thomas Petazzoni]

Hello,

On Tue, 5 Jun 2018 14:39:59 +0200, Florian La Roche wrote:
> More complete usage string for the logging service.
> 
> 
> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>

A better commit log for this one would be:

busybox: fix usage string in S01logging

The S01logging usage text doesn't document the reload target, even
though it exists, so fix that.

Signed-off-by: ...

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] More complete usage string.

[Arnout Vandecappelle]

 [+ Carlos who is working on init scripts]

On 05-06-18 14:39, Florian La Roche wrote:
> More complete usage string for the logging service.
> 
> 
> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
> ---
>  package/busybox/S01logging | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
> index 4632a4cc99..fcb3e7d236 100644
> --- a/package/busybox/S01logging
> +++ b/package/busybox/S01logging
> @@ -33,7 +33,7 @@ case "$1" in
>  	start
>  	;;
>    *)
> -	echo "Usage: $0 {start|stop|restart}"
> +	echo "Usage: $0 {start|stop|restart|reload}"

 For this one, we should perhaps first decide on what we want to do in general
with the init scripts. Do we want to define a reload target? And if we do, and
it is equal to the restart target, do we want to have it in the help text?

 First some statistics. We currently have:

- 109 init scripts
-  75 define 'reload', 12 define 'force-reload', 6 both (so 81 total)
-  63 define 'reload' as 'restart'
-   7 define 'reload' as something else
- 107 provide help text
-  31 provide help text for 'reload'
-  13 of the 63 that define reload == restart provide help text for reload
-   7 of the 7 that define reload != restart provide help text for reload


 So my proposal for the "norm" would be:

- always defines reload
- only document reload if reload != restart
- decide what to do with force-reload later

 Carlos, what do you think?


 In short, I would not apply this patch.

 Regards,
 Arnout

>  	exit 1
>  esac
>  
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] More complete usage string.

[Carlos Santos]

> From: "Arnout Vandecappelle" <arnout@mind.be>
> To: "Florian La Roche" <F.LaRoche@pilz.de>, "buildroot" <buildroot@buildroot.org>, "Carlos Santos"
> <casantos@datacom.ind.br>
> Cc: "ratbert90" <aduskett@gmail.com>
> Sent: Tuesday, June 5, 2018 5:06:39 PM
> Subject: Re: [Buildroot] [PATCH 1/1] More complete usage string.

> [+ Carlos who is working on init scripts]
> 
> On 05-06-18 14:39, Florian La Roche wrote:
>> More complete usage string for the logging service.
>> 
>> 
>> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
>> ---
>>  package/busybox/S01logging | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
>> index 4632a4cc99..fcb3e7d236 100644
>> --- a/package/busybox/S01logging
>> +++ b/package/busybox/S01logging
>> @@ -33,7 +33,7 @@ case "$1" in
>>  	start
>>  	;;
>>    *)
>> -	echo "Usage: $0 {start|stop|restart}"
>> +	echo "Usage: $0 {start|stop|restart|reload}"
> 
> For this one, we should perhaps first decide on what we want to do in general
> with the init scripts. Do we want to define a reload target? And if we do, and
> it is equal to the restart target, do we want to have it in the help text?
> 
> First some statistics. We currently have:
> 
> - 109 init scripts
> -  75 define 'reload', 12 define 'force-reload', 6 both (so 81 total)
> -  63 define 'reload' as 'restart'
> -   7 define 'reload' as something else
> - 107 provide help text
> -  31 provide help text for 'reload'
> -  13 of the 63 that define reload == restart provide help text for reload
> -   7 of the 7 that define reload != restart provide help text for reload
> 
> 
> So my proposal for the "norm" would be:
> 
> - always defines reload
> - only document reload if reload != restart

I'd document it anyway, since it is still a valid argument.

> - decide what to do with force-reload later
> 
> Carlos, what do you think?

I agree. Reload in general means "keep running but reload the
configuration" while restart means stop, pause, start.

> In short, I would not apply this patch.

I would apply the patch, for the same reason above.

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer