* [Buildroot] [PATCH] imx-usb-loader: propagate libusb dependency
@ 2018-06-06 20:04 Baruch Siach
2018-06-06 20:12 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2018-06-06 20:04 UTC (permalink / raw)
To: buildroot
Avoid select of libusb when the toolchain does not support threads.
Fixes:
http://autobuild.buildroot.net/results/a21/a212ee3e5ec174f4e6e7d582f777325dac035bfd/
Cc: Adam Duskett <aduskett@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/imx-usb-loader/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/imx-usb-loader/Config.in b/package/imx-usb-loader/Config.in
index 6f083f34d12a..1cc0dd8c25e7 100644
--- a/package/imx-usb-loader/Config.in
+++ b/package/imx-usb-loader/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_IMX_USB_LOADER
bool "imx-usb-loader"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
select BR2_PACKAGE_LIBUSB
help
This package contains tools to download and execute code
@@ -7,3 +8,6 @@ config BR2_PACKAGE_IMX_USB_LOADER
Serial Download Protocol.
https://github.com/boundarydevices/imx_usb_loader
+
+comment "imx-usb-loader needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] imx-usb-loader: propagate libusb dependency
2018-06-06 20:04 [Buildroot] [PATCH] imx-usb-loader: propagate libusb dependency Baruch Siach
@ 2018-06-06 20:12 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-06-06 20:12 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 6 Jun 2018 23:04:39 +0300, Baruch Siach wrote:
> Avoid select of libusb when the toolchain does not support threads.
>
> Fixes:
> http://autobuild.buildroot.net/results/a21/a212ee3e5ec174f4e6e7d582f777325dac035bfd/
>
> Cc: Adam Duskett <aduskett@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/imx-usb-loader/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
I'm wondering how I could have missed that during the review. Thanks
for pointing it out and proposing a patch to fix it! Applied!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-06 20:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 20:04 [Buildroot] [PATCH] imx-usb-loader: propagate libusb dependency Baruch Siach
2018-06-06 20:12 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox