Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] host-cargo: select host-rustc
Date: Thu, 7 Jun 2018 18:02:50 +0200	[thread overview]
Message-ID: <20180607180250.0df17b2f@windsurf> (raw)
In-Reply-To: <20180606202501.14535-1-fontaine.fabrice@gmail.com>

Hello,

On Wed,  6 Jun 2018 22:25:00 +0200, Fabrice Fontaine wrote:
> Buildroot documentation specifies that cargo-based package should only
> depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects
> BR2_PACKAGE_HOST_CARGO but this does not work as host-cargo depends on
> BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is
> selected.

What "does not work" exactly ?

Yes, you end up with host-rust being built as a dependency of
host-cargo, while BR2_PACKAGE_HOST_RUST is not enabled.

But for host packages, we currently don't enforce that their
Config.in.host option is enabled when the package is built.

So, which problem have you encountered ?

I agree that your patch makes sense (it's better to have the
Config.in.host option enabled when the corresponding host package is
going to be built), but I don't see where the *problem* is, so I'd like
to understand before applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-06-07 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 20:25 [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Fabrice Fontaine
2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
2018-06-07  2:39   ` Baruch Siach
2018-06-07  5:58   ` Thomas Petazzoni
2018-06-07 17:26     ` Fabrice Fontaine
2018-06-07 16:02 ` Thomas Petazzoni [this message]
2018-06-07 17:25   ` [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607180250.0df17b2f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox