From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc
Date: Sun, 10 Jun 2018 16:18:51 +0200 [thread overview]
Message-ID: <20180610161851.2acb3a98@windsurf> (raw)
In-Reply-To: <20180610133857.4737-1-fontaine.fabrice@gmail.com>
Hello,
On Sun, 10 Jun 2018 15:38:56 +0200, Fabrice Fontaine wrote:
> Buildroot documentation specifies that cargo-based package should only
> depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects
> BR2_PACKAGE_HOST_CARGO but this fails with the following error:
>
> warning: (BR2_PACKAGE_LIBRSVG) selects BR2_PACKAGE_HOST_CARGO which has
> unmet direct dependencies (BR2_PACKAGE_HAS_HOST_RUSTC)
>
> Indeed, host-cargo depends on
> BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is
> selected.
>
> So instead of having to select both cargo and rustc in each cargo-based
> package, replace BR2_PACKAGE_HAS_HOST_RUSTC dependency by
> BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and select
> BR2_PACKAGE_HOST_RUSTC
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Thomas Petazzoni)
> - Give more details on what does not work in commit log
Applied to master, thanks. I have also applied a follow-up patch that
removes BR2_PACKAGE_HAS_HOST_RUSTC entirely, since it was no longer
used anywhere.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-06-10 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 13:38 [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc Fabrice Fontaine
2018-06-10 13:38 ` [Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
2018-06-10 14:25 ` Thomas Petazzoni
2018-06-12 6:58 ` Peter Korsgaard
2018-06-12 19:47 ` Fabrice Fontaine
2018-06-12 20:18 ` Peter Korsgaard
2018-06-12 20:42 ` Thomas Petazzoni
2018-07-16 11:19 ` Thomas Petazzoni
2018-06-10 14:18 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180610161851.2acb3a98@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox