Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5
Date: Tue, 12 Jun 2018 22:42:55 +0200	[thread overview]
Message-ID: <20180612224255.75df55bf@windsurf> (raw)
In-Reply-To: <87k1r369n9.fsf@dell.be.48ers.dk>

Hello,

On Tue, 12 Jun 2018 22:18:50 +0200, Peter Korsgaard wrote:

>  >> This also causes a number of issues for host-librsvg (which is a
>  >> dependency of libgtk3 and midori) when building for architectures not
>  >> supported by rust:
>  >>   
>  > The issue isn't related to libgtk3 and midori as this build fails (
>  > http://autobuild.buildroot.net/results/f33/f335ed517b402c094ed3b10a3da4cdc23620dbd6/defconfig)
>  > even if these packages are not selected.  
> 
> It is a bit more tricky than that because it can also be about
> host-libgtk3. For this configuration it is adwaita-icon-theme which
> pulls in host-libgtk3 -> host-librsvg -> host-cargo -> host-rustc

I think there is an issue in how we handle rust in fact. Indeed, the
BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS option indicates if the Rust
compiler is capable to act as a cross-compiler for the selected target.

But we haven't accounted for the fact that the Rust compiler can also
do native builds, like it does for host-librsvg. In the case of native
builds, we don't care whether Rust has support for the target
architecture: we care about it having support for the host architecture.

So basically, the fact that Rust is both a native compiler and a
cross-compiler is not properly accounted today.

Perhaps we need to have two separate
BR2_PACKAGE_HOST_RUSTC_something_ARCH_SUPPORTS options, to use
depending on whether you need Rust support for the target, or Rust
support for the host ?

Eric, what do you think ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-06-12 20:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10 13:38 [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc Fabrice Fontaine
2018-06-10 13:38 ` [Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
2018-06-10 14:25   ` Thomas Petazzoni
2018-06-12  6:58     ` Peter Korsgaard
2018-06-12 19:47       ` Fabrice Fontaine
2018-06-12 20:18         ` Peter Korsgaard
2018-06-12 20:42           ` Thomas Petazzoni [this message]
2018-07-16 11:19   ` Thomas Petazzoni
2018-06-10 14:18 ` [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612224255.75df55bf@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox