Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libusb: add an option to compile examples
Date: Sun, 10 Jun 2018 12:36:20 -0400	[thread overview]
Message-ID: <20180610163620.k7mtdvg3bin7crad@archlinux> (raw)
In-Reply-To: <20180610143529.xpleqn3dg5gmufpd@sapphire.tkos.co.il>

Hi Baruch,

On Sun, Jun 10, 2018 at 05:35:29PM +0300, Baruch Siach wrote:
> > diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> > index aee3622f8d..89ec91bb42 100644
> > --- a/package/libusb/libusb.mk
> > +++ b/package/libusb/libusb.mk
> > @@ -25,5 +25,16 @@ else
> >  LIBUSB_CONF_OPTS += --disable-udev
> >  endif
> >  
> > +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> > +LIBUSB_CONF_OPTS += --enable-examples-build
> > +define LIBUSB_INSTALL_TARGET_EXAMPLES
> > +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
> > +		[ -x $(@D)/examples/$${example} ] || continue; \
> 
> Why is this file presence check needed?
>

Because, some of the examples are compiled under HAVE_xxx condition.

See the extract of examples/Makefile.am below.

	noinst_PROGRAMS = listdevs xusb fxload hotplugtest testlibusb
	
	if HAVE_SIGACTION
	noinst_PROGRAMS += dpfp
	
	if THREADS_POSIX
	dpfp_threaded_CFLAGS = $(AM_CFLAGS)
	noinst_PROGRAMS += dpfp_threaded
	endif
	
	sam3u_benchmark_SOURCES = sam3u_benchmark.c
	noinst_PROGRAMS += sam3u_benchmark
	endif

> > +		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
> > +	done
> > +endef
> > +LIBUSB_POST_INSTALL_TARGET_HOOKS += LIBUSB_INSTALL_TARGET_EXAMPLES
> > +endif
> > +
> >  $(eval $(autotools-package))
> >  $(eval $(host-autotools-package))
>
> baruch
> 
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Regards,
Gael

  reply	other threads:[~2018-06-10 16:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10 14:03 [Buildroot] [PATCH] libusb: add an option to compile examples Gaël PORTAY
2018-06-10 14:35 ` Baruch Siach
2018-06-10 16:36   ` Gaël PORTAY [this message]
2018-06-10 17:25     ` Baruch Siach
2018-06-10 22:05       ` Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180610163620.k7mtdvg3bin7crad@archlinux \
    --to=gael.portay@savoirfairelinux.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox