Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libusb: add an option to compile examples
@ 2018-06-10 14:03 Gaël PORTAY
  2018-06-10 14:35 ` Baruch Siach
  0 siblings, 1 reply; 5+ messages in thread
From: Gaël PORTAY @ 2018-06-10 14:03 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
 package/libusb/Config.in |  7 +++++++
 package/libusb/libusb.mk | 11 +++++++++++
 2 files changed, 18 insertions(+)

diff --git a/package/libusb/Config.in b/package/libusb/Config.in
index 5238588aa8..d31a717fdf 100644
--- a/package/libusb/Config.in
+++ b/package/libusb/Config.in
@@ -6,5 +6,12 @@ config BR2_PACKAGE_LIBUSB
 
 	  http://libusb.info/
 
+if BR2_PACKAGE_LIBUSB
+
+config BR2_PACKAGE_LIBUSB_EXAMPLES
+	bool "build libusb examples"
+
+endif
+
 comment "libusb needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
index aee3622f8d..89ec91bb42 100644
--- a/package/libusb/libusb.mk
+++ b/package/libusb/libusb.mk
@@ -25,5 +25,16 @@ else
 LIBUSB_CONF_OPTS += --disable-udev
 endif
 
+ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
+LIBUSB_CONF_OPTS += --enable-examples-build
+define LIBUSB_INSTALL_TARGET_EXAMPLES
+	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
+		[ -x $(@D)/examples/$${example} ] || continue; \
+		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
+	done
+endef
+LIBUSB_POST_INSTALL_TARGET_HOOKS += LIBUSB_INSTALL_TARGET_EXAMPLES
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libusb: add an option to compile examples
  2018-06-10 14:03 [Buildroot] [PATCH] libusb: add an option to compile examples Gaël PORTAY
@ 2018-06-10 14:35 ` Baruch Siach
  2018-06-10 16:36   ` Gaël PORTAY
  0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-06-10 14:35 UTC (permalink / raw)
  To: buildroot

Hi Ga?l,

On Sun, Jun 10, 2018 at 10:03:16AM -0400, Ga?l PORTAY wrote:
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  package/libusb/Config.in |  7 +++++++
>  package/libusb/libusb.mk | 11 +++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/package/libusb/Config.in b/package/libusb/Config.in
> index 5238588aa8..d31a717fdf 100644
> --- a/package/libusb/Config.in
> +++ b/package/libusb/Config.in
> @@ -6,5 +6,12 @@ config BR2_PACKAGE_LIBUSB
>  
>  	  http://libusb.info/
>  
> +if BR2_PACKAGE_LIBUSB
> +
> +config BR2_PACKAGE_LIBUSB_EXAMPLES
> +	bool "build libusb examples"
> +
> +endif
> +
>  comment "libusb needs a toolchain w/ threads"
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> index aee3622f8d..89ec91bb42 100644
> --- a/package/libusb/libusb.mk
> +++ b/package/libusb/libusb.mk
> @@ -25,5 +25,16 @@ else
>  LIBUSB_CONF_OPTS += --disable-udev
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> +LIBUSB_CONF_OPTS += --enable-examples-build
> +define LIBUSB_INSTALL_TARGET_EXAMPLES
> +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
> +		[ -x $(@D)/examples/$${example} ] || continue; \

Why is this file presence check needed?

> +		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
> +	done
> +endef
> +LIBUSB_POST_INSTALL_TARGET_HOOKS += LIBUSB_INSTALL_TARGET_EXAMPLES
> +endif
> +
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libusb: add an option to compile examples
  2018-06-10 14:35 ` Baruch Siach
@ 2018-06-10 16:36   ` Gaël PORTAY
  2018-06-10 17:25     ` Baruch Siach
  0 siblings, 1 reply; 5+ messages in thread
From: Gaël PORTAY @ 2018-06-10 16:36 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

On Sun, Jun 10, 2018 at 05:35:29PM +0300, Baruch Siach wrote:
> > diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> > index aee3622f8d..89ec91bb42 100644
> > --- a/package/libusb/libusb.mk
> > +++ b/package/libusb/libusb.mk
> > @@ -25,5 +25,16 @@ else
> >  LIBUSB_CONF_OPTS += --disable-udev
> >  endif
> >  
> > +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> > +LIBUSB_CONF_OPTS += --enable-examples-build
> > +define LIBUSB_INSTALL_TARGET_EXAMPLES
> > +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
> > +		[ -x $(@D)/examples/$${example} ] || continue; \
> 
> Why is this file presence check needed?
>

Because, some of the examples are compiled under HAVE_xxx condition.

See the extract of examples/Makefile.am below.

	noinst_PROGRAMS = listdevs xusb fxload hotplugtest testlibusb
	
	if HAVE_SIGACTION
	noinst_PROGRAMS += dpfp
	
	if THREADS_POSIX
	dpfp_threaded_CFLAGS = $(AM_CFLAGS)
	noinst_PROGRAMS += dpfp_threaded
	endif
	
	sam3u_benchmark_SOURCES = sam3u_benchmark.c
	noinst_PROGRAMS += sam3u_benchmark
	endif

> > +		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
> > +	done
> > +endef
> > +LIBUSB_POST_INSTALL_TARGET_HOOKS += LIBUSB_INSTALL_TARGET_EXAMPLES
> > +endif
> > +
> >  $(eval $(autotools-package))
> >  $(eval $(host-autotools-package))
>
> baruch
> 
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Regards,
Gael

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libusb: add an option to compile examples
  2018-06-10 16:36   ` Gaël PORTAY
@ 2018-06-10 17:25     ` Baruch Siach
  2018-06-10 22:05       ` Gaël PORTAY
  0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-06-10 17:25 UTC (permalink / raw)
  To: buildroot

Hi Ga?l,

On Sun, Jun 10, 2018 at 12:36:20PM -0400, Ga?l PORTAY wrote:
> On Sun, Jun 10, 2018 at 05:35:29PM +0300, Baruch Siach wrote:
> > > diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> > > index aee3622f8d..89ec91bb42 100644
> > > --- a/package/libusb/libusb.mk
> > > +++ b/package/libusb/libusb.mk
> > > @@ -25,5 +25,16 @@ else
> > >  LIBUSB_CONF_OPTS += --disable-udev
> > >  endif
> > >  
> > > +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> > > +LIBUSB_CONF_OPTS += --enable-examples-build
> > > +define LIBUSB_INSTALL_TARGET_EXAMPLES
> > > +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
> > > +		[ -x $(@D)/examples/$${example} ] || continue; \
> > 
> > Why is this file presence check needed?
> 
> Because, some of the examples are compiled under HAVE_xxx condition.
> 
> See the extract of examples/Makefile.am below.
> 
> 	noinst_PROGRAMS = listdevs xusb fxload hotplugtest testlibusb
> 	
> 	if HAVE_SIGACTION
> 	noinst_PROGRAMS += dpfp
> 	
> 	if THREADS_POSIX
> 	dpfp_threaded_CFLAGS = $(AM_CFLAGS)
> 	noinst_PROGRAMS += dpfp_threaded
> 	endif
> 	
> 	sam3u_benchmark_SOURCES = sam3u_benchmark.c
> 	noinst_PROGRAMS += sam3u_benchmark
> 	endif

All Buildroot libcs support sigaction. Also, libusb depends on threads 
support, so THREADS_POSIX is always true in Buildroot.

So I think this check is not needed.

baruch

> > > +		cp -dpfr $(@D)/examples/$${example} $(TARGET_DIR)/usr/bin; \
> > > +	done
> > > +endef
> > > +LIBUSB_POST_INSTALL_TARGET_HOOKS += LIBUSB_INSTALL_TARGET_EXAMPLES
> > > +endif
> > > +
> > >  $(eval $(autotools-package))
> > >  $(eval $(host-autotools-package))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libusb: add an option to compile examples
  2018-06-10 17:25     ` Baruch Siach
@ 2018-06-10 22:05       ` Gaël PORTAY
  0 siblings, 0 replies; 5+ messages in thread
From: Gaël PORTAY @ 2018-06-10 22:05 UTC (permalink / raw)
  To: buildroot

Baruch,

On Sun, Jun 10, 2018 at 08:25:44PM +0300, Baruch Siach wrote:
> (...)
Hi Ga?l,
> 
> On Sun, Jun 10, 2018 at 12:36:20PM -0400, Ga?l PORTAY wrote:
> > On Sun, Jun 10, 2018 at 05:35:29PM +0300, Baruch Siach wrote:
> > > > diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
> > > > index aee3622f8d..89ec91bb42 100644
> > > > --- a/package/libusb/libusb.mk
> > > > +++ b/package/libusb/libusb.mk
> > > > @@ -25,5 +25,16 @@ else
> > > >  LIBUSB_CONF_OPTS += --disable-udev
> > > >  endif
> > > >  
> > > > +ifeq ($(BR2_PACKAGE_LIBUSB_EXAMPLES),y)
> > > > +LIBUSB_CONF_OPTS += --enable-examples-build
> > > > +define LIBUSB_INSTALL_TARGET_EXAMPLES
> > > > +	for example in listdevs xusb fxload hotplugtest testlibusb dpfp dpfp_threaded sam3u_benchmark ; do \
> > > > +		[ -x $(@D)/examples/$${example} ] || continue; \
> > > 
> > > Why is this file presence check needed?
> > 
> > Because, some of the examples are compiled under HAVE_xxx condition.
> > 
> > See the extract of examples/Makefile.am below.
> > 
> > 	noinst_PROGRAMS = listdevs xusb fxload hotplugtest testlibusb
> > 	
> > 	if HAVE_SIGACTION
> > 	noinst_PROGRAMS += dpfp
> > 	
> > 	if THREADS_POSIX
> > 	dpfp_threaded_CFLAGS = $(AM_CFLAGS)
> > 	noinst_PROGRAMS += dpfp_threaded
> > 	endif
> > 	
> > 	sam3u_benchmark_SOURCES = sam3u_benchmark.c
> > 	noinst_PROGRAMS += sam3u_benchmark
> > 	endif
> 
> All Buildroot libcs support sigaction. Also, libusb depends on threads 
> support, so THREADS_POSIX is always true in Buildroot.
> 
> So I think this check is not needed.
> 

Okay, I will send a v2 without this check.

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-10 22:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-10 14:03 [Buildroot] [PATCH] libusb: add an option to compile examples Gaël PORTAY
2018-06-10 14:35 ` Baruch Siach
2018-06-10 16:36   ` Gaël PORTAY
2018-06-10 17:25     ` Baruch Siach
2018-06-10 22:05       ` Gaël PORTAY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox