From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] modem-manager: update package prompt name
Date: Fri, 15 Jun 2018 22:33:16 +0200 [thread overview]
Message-ID: <20180615223316.6279b32a@windsurf> (raw)
In-Reply-To: <20180615193753.GB27644@x230>
Hello,
On Fri, 15 Jun 2018 21:37:54 +0200, Petr Vorel wrote:
> > diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> > index 226f82f4f6..c4c723776d 100644
> > --- a/package/modem-manager/Config.in
> > +++ b/package/modem-manager/Config.in
> > @@ -1,5 +1,5 @@
> > config BR2_PACKAGE_MODEM_MANAGER
> > - bool "modemmanager"
> > + bool "modem-manager"
> Sorry I should have thought twice before acking this.
> It's not that important, but better would be to call it ModemManager, as that's its name.
> And network-manager (called now networkmanager) as NetworkManager...
We normally try to be consistent between the package/<pkg>/
directory name and the prompt used in menuconfig.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-15 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 19:33 [Buildroot] [git commit] modem-manager: update package prompt name Thomas Petazzoni
2018-06-15 19:37 ` Petr Vorel
2018-06-15 19:44 ` Petr Vorel
2018-06-15 20:33 ` Thomas Petazzoni [this message]
2018-06-15 21:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615223316.6279b32a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox